Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated S3 set up #4629

Merged
merged 3 commits into from Mar 22, 2023
Merged

updated S3 set up #4629

merged 3 commits into from Mar 22, 2023

Conversation

thetif
Copy link
Contributor

@thetif thetif commented Mar 22, 2023

Resolves issue with opening docs and uploading images

Description

The S3 set up changed, this fixes the issues.

Steps to manually verify this change

  1. Verify that clicking How to Get Started opens the correct PDF
  2. Verify that clicking How to Access the eAPD opens the correct PDF
  3. Verify that clicking State Administrator Authorization Form opens the correct PDF
  4. Log in
  5. Open an APD
  6. Upload an image to a RichText field
  7. Verify that there is no error and the image is added
  8. Navigate back to the dashboard and then back to the APD
  9. Verify that the image is still displaying correctly

This pull request is ready to code review when

  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor
  • The experience passes a basic manual accessibility audit (keyboard nav,
    screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #4629 (a89249f) into main (24e7840) will decrease coverage by 12.75%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4629       +/-   ##
===========================================
- Coverage   94.32%   81.58%   -12.75%     
===========================================
  Files         273      263       -10     
  Lines        8694     8205      -489     
  Branches     1746     1734       -12     
===========================================
- Hits         8201     6694     -1507     
- Misses        469     1454      +985     
- Partials       24       57       +33     
Flag Coverage Δ
api ∅ <ø> (∅)
common 100.00% <ø> (ø)
web 80.69% <ø> (-13.38%) ⬇️

see 66 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24e7840...a89249f. Read the comment docs.

@@ -82,6 +82,11 @@ services:
- DEV_DB_NAME=${DEV_DB_NAME:-hitech_apd}
- TEST_DB_NAME=${TEST_DB_NAME:-hitech_apd_test}
- LD_API_KEY=${LD_API_KEY}
- FILE_STORE=${FILE_STORE}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these variables let us use S3 locally if we set them in our env

@cms-eapd-bot
Copy link

cms-eapd-bot commented Mar 22, 2023

See this pull request in action: https://ec2-34-195-82-250.compute-1.amazonaws.com

a89249f

@thetif thetif merged commit df4dccd into main Mar 22, 2023
8 of 9 checks passed
@thetif thetif deleted the tforkner/s3-update branch March 22, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants