New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated S3 set up #4629
updated S3 set up #4629
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4629 +/- ##
===========================================
- Coverage 94.32% 81.58% -12.75%
===========================================
Files 273 263 -10
Lines 8694 8205 -489
Branches 1746 1734 -12
===========================================
- Hits 8201 6694 -1507
- Misses 469 1454 +985
- Partials 24 57 +33
see 66 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -82,6 +82,11 @@ services: | |||
- DEV_DB_NAME=${DEV_DB_NAME:-hitech_apd} | |||
- TEST_DB_NAME=${TEST_DB_NAME:-hitech_apd_test} | |||
- LD_API_KEY=${LD_API_KEY} | |||
- FILE_STORE=${FILE_STORE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these variables let us use S3 locally if we set them in our env
See this pull request in action: https://ec2-34-195-82-250.compute-1.amazonaws.com |
Resolves issue with opening docs and uploading images
Description
The S3 set up changed, this fixes the issues.
Steps to manually verify this change
This pull request is ready to code review when
tests, refactor
screenreader, text scaling) OR an exemption is documented
This pull request is ready to test when
This pull request is ready to review when QA has
This pull request can be merged when