Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bbrooks/security hub findings 20230320 #4664

Merged
merged 8 commits into from Apr 6, 2023

Conversation

cthulhuplus
Copy link
Contributor

Resolves # 4620

Description

Attempts to address security concerns by making sure our instances are up to date when deployed.

Chromatic Link

Significant changes or possible side effects

Automated test cases written

Given When Then Type (jest, tap, cypress)

Steps to manually verify this change

This pull request is ready to code review when

  • Automated tests are updated (and all tests are passing)
  • New automated test cases are documented above
  • Chromatic link added above
  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav,
    screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #4664 (6ebd1b1) into main (bfbcd7b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4664   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files         281      281           
  Lines        8898     8898           
  Branches     1797     1797           
=======================================
  Hits         8399     8399           
  Misses        475      475           
  Partials       24       24           
Flag Coverage Δ
api ∅ <ø> (∅)
common 99.33% <ø> (ø)
web 94.12% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfbcd7b...6ebd1b1. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Apr 5, 2023

This deploy was cleaned up.

@cthulhuplus cthulhuplus requested review from thetif and tbolt and removed request for thetif April 6, 2023 17:16
@cthulhuplus cthulhuplus merged commit 92ff340 into main Apr 6, 2023
12 checks passed
@cthulhuplus cthulhuplus deleted the bbrooks/SecurityHub-Findings-20230320 branch April 6, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants