New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bbrooks/3670-Improve-Provisioning-Script-Cleanup #4666
Merged
cthulhuplus
merged 12 commits into
main
from
bbrooks/3670-Improve-Provisioning-Script-Cleanup
Apr 7, 2023
Merged
bbrooks/3670-Improve-Provisioning-Script-Cleanup #4666
cthulhuplus
merged 12 commits into
main
from
bbrooks/3670-Improve-Provisioning-Script-Cleanup
Apr 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhuplus
changed the title
Bbrooks/3670 improve provisioning script cleanup
bbrooks/3670-Improve-Provisioning-Script-Cleanup
Apr 6, 2023
Codecov Report
@@ Coverage Diff @@
## main #4666 +/- ##
=======================================
Coverage 94.39% 94.39%
=======================================
Files 281 281
Lines 8898 8898
Branches 1797 1797
=======================================
Hits 8399 8399
Misses 475 475
Partials 24 24
Continue to review full report in Codecov by Sentry.
|
tbolt
approved these changes
Apr 6, 2023
This deploy was cleaned up. |
…tps://github.com/Enterprise-CMCS/eAPD into bbrooks/3670-Improve-Provisioning-Script-Cleanup
amyd11
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves # 3670
Description
The mechanism for cleaning up the infrastructure was broken, I believe this fixes it and that it should run every 4 hours now.
Chromatic Link
Significant changes or possible side effects
Automated test cases written
Steps to manually verify this change
This pull request is ready to code review when
tests, refactor
screenreader, text scaling) OR an exemption is documented
This pull request is ready to test when
This pull request is ready to review when QA has
This pull request can be merged when