Merge pull request #30 from CMSgov/mk-tf-pre-commit-hooks

Terraform fmt pre-commit hook
Enterprise-CMCS · Aug 16, 2021 · c4f0b26 · c4f0b26
2 parents e6bfeeb + 96735f9
commit c4f0b26
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 14 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -1,13 +1,13 @@
 repos:
   - repo: git://github.com/pre-commit/pre-commit-hooks
-    rev: v3.4.0
+    rev: v4.0.1
     hooks:
       - id: check-merge-conflict
       - id: detect-private-key
       - id: trailing-whitespace
 
   - repo: git://github.com/igorshubovych/markdownlint-cli
-    rev: v0.26.0
+    rev: v0.28.1
     hooks:
       - id: markdownlint
 
@@ -21,3 +21,8 @@ repos:
     rev: 1.0.5
     hooks:
       - id: shell-lint
+
+  - repo: git://github.com/antonbabenko/pre-commit-terraform
+    rev: v1.50.0
+    hooks:
+      - id: terraform_fmt
diff --git a/ecr.tf b/ecr.tf
@@ -17,7 +17,7 @@ resource "aws_ecr_repository" "main" {
 
 resource "aws_ecr_lifecycle_policy" "main" {
   repository = aws_ecr_repository.main.name
-  policy = local.policy
+  policy     = local.policy
 }
 
 # attach a ECR policy to a repository and give read only cross account access to external principal accounts

diff --git a/variables.tf b/variables.tf
@@ -6,7 +6,7 @@ variable "container_name" {
 }
 
 variable "allowed_read_principals" {
-  type        = list
+  type        = list(any)
   description = "External principals that are allowed to read from the ECR repository"
 }
 
@@ -41,7 +41,7 @@ variable "environment" {
 }
 
 variable "ecs_vpc_id" {
-  type = string
+  type        = string
   description = "VPC ID to be used by ECS"
 }
 
@@ -61,16 +61,16 @@ variable "logs_cloudwatch_group_arn" {
   type        = string
 }
 
- variable "ecs_cluster_arn" {
-   description = "ECS cluster ARN to use for running this profile"
-   type        = string
-   default     = ""
- }
+variable "ecs_cluster_arn" {
+  description = "ECS cluster ARN to use for running this profile"
+  type        = string
+  default     = ""
+}
 
- variable "ecs_desired_count" {
-   description = "Desired task count for ECS service"
-   type        = number
- }
+variable "ecs_desired_count" {
+  description = "Desired task count for ECS service"
+  type        = number
+}
 
 # GitHub Runner Variables