Cypress fix2 #11081
Merged
Cypress fix2 #11081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tblackwe
requested review from
karla-vm,
TheDanMiller,
BearHanded,
braxex,
ntsummers1 and
scwambach
as code owners
karla-vm
approved these changes
Feb 21, 2023
ntsummers1
approved these changes
Feb 21, 2023
oweingrod-coforma
referenced
this pull request
in oweingrod-coforma/macpro-mdct-mcr
Feb 27, 2023
* cypress fix and version bump * updating audit version, disabling pa11y on local * pre-commit action dislikes this.
tblackwe
added a commit
that referenced
this pull request
Feb 28, 2023
* Cypress fix2 (#11081) * cypress fix and version bump * updating audit version, disabling pa11y on local * pre-commit action dislikes this. * MDCT-2264: Create S3 Buckets + DynamoDB Table for MLR (#11079) * adding MLR resources * indentation and reference fix * serverless fix * how about I actually fix it * duplicate removal * naaar tables and form buckets (#11087) * Clean up reporting APIs. (#11082) * Add new error constants for Dynamo errors Error constants nerw constant * Refactor reports/create.ts to handle errors more cleanly Fix create route * Refactor reports/archive.ts to handle errors more cleanly Archive test should be calling `archive` route. Previously, tests were calling `update` route. * Refactor reports/fetch.ts to handle errors more cleanly * Missing a required argument should return a `400` not a `500`. Update test asserts to expect new status codes and error messages. * Refactor reports/update.ts to handle errors more clearly Reorganize code to move returned errors closer to their conditional checks. Adds additional error handling for S3 and Dynamo, and removes (likely) un-needed logic to archive reports from this route. Remove duplicate `update` test. * Archive route should ensure credentials * Fetch handler was looking for wrong path parameter * Add new discrete handler for archiving reports. * Point archive button to the archive handler Instead of the update handler * Statusing completeness checker (#11095) * shelving progress * working on getting a basic test to work * basic standard form validation * adding fixtures * more basic completion check * shelving progress * I want to keep record of this, but it will change. * mid-refactor, but time for guitar lessons * one last quick checkin * I've got 99 problems and all of them are async * commenting out broken tests, fixing async * started creation of required schema * updating fixture to fail, removing review/submit * new form test * new completion function * now with modals * Some changes and empty plan fixture * params for fixture testing * resolved test, renamed functions * extracting completion check into it's own file * extracted code into seperate file * adding conditional calculation to fetch * resolving issue with new reports * cleaning up testing fixtures * adding comments --------- Co-authored-by: Thomas Blackwell <thomas.blackwell@coforma.io> Co-authored-by: Karla Valcárcel Martínez <99458559+karla-vm@users.noreply.github.com>
lindseybaron
pushed a commit
that referenced
this pull request
Mar 6, 2023
* Cypress fix2 (#11081) * cypress fix and version bump * updating audit version, disabling pa11y on local * pre-commit action dislikes this. * MDCT-2264: Create S3 Buckets + DynamoDB Table for MLR (#11079) * adding MLR resources * indentation and reference fix * serverless fix * how about I actually fix it * duplicate removal * naaar tables and form buckets (#11087) * Clean up reporting APIs. (#11082) * Add new error constants for Dynamo errors Error constants nerw constant * Refactor reports/create.ts to handle errors more cleanly Fix create route * Refactor reports/archive.ts to handle errors more cleanly Archive test should be calling `archive` route. Previously, tests were calling `update` route. * Refactor reports/fetch.ts to handle errors more cleanly * Missing a required argument should return a `400` not a `500`. Update test asserts to expect new status codes and error messages. * Refactor reports/update.ts to handle errors more clearly Reorganize code to move returned errors closer to their conditional checks. Adds additional error handling for S3 and Dynamo, and removes (likely) un-needed logic to archive reports from this route. Remove duplicate `update` test. * Archive route should ensure credentials * Fetch handler was looking for wrong path parameter * Add new discrete handler for archiving reports. * Point archive button to the archive handler Instead of the update handler * Statusing completeness checker (#11095) * shelving progress * working on getting a basic test to work * basic standard form validation * adding fixtures * more basic completion check * shelving progress * I want to keep record of this, but it will change. * mid-refactor, but time for guitar lessons * one last quick checkin * I've got 99 problems and all of them are async * commenting out broken tests, fixing async * started creation of required schema * updating fixture to fail, removing review/submit * new form test * new completion function * now with modals * Some changes and empty plan fixture * params for fixture testing * resolved test, renamed functions * extracting completion check into it's own file * extracted code into seperate file * adding conditional calculation to fetch * resolving issue with new reports * cleaning up testing fixtures * adding comments --------- Co-authored-by: Thomas Blackwell <thomas.blackwell@coforma.io> Co-authored-by: Karla Valcárcel Martínez <99458559+karla-vm@users.noreply.github.com>
oweingrod-coforma
added a commit
that referenced
this pull request
Mar 6, 2023
* Cypress fix2 (#11081) * cypress fix and version bump * updating audit version, disabling pa11y on local * pre-commit action dislikes this. * MDCT-2264: Create S3 Buckets + DynamoDB Table for MLR (#11079) * adding MLR resources * indentation and reference fix * serverless fix * how about I actually fix it * duplicate removal * naaar tables and form buckets (#11087) * Clean up reporting APIs. (#11082) * Add new error constants for Dynamo errors Error constants nerw constant * Refactor reports/create.ts to handle errors more cleanly Fix create route * Refactor reports/archive.ts to handle errors more cleanly Archive test should be calling `archive` route. Previously, tests were calling `update` route. * Refactor reports/fetch.ts to handle errors more cleanly * Missing a required argument should return a `400` not a `500`. Update test asserts to expect new status codes and error messages. * Refactor reports/update.ts to handle errors more clearly Reorganize code to move returned errors closer to their conditional checks. Adds additional error handling for S3 and Dynamo, and removes (likely) un-needed logic to archive reports from this route. Remove duplicate `update` test. * Archive route should ensure credentials * Fetch handler was looking for wrong path parameter * Add new discrete handler for archiving reports. * Point archive button to the archive handler Instead of the update handler * Statusing completeness checker (#11095) * shelving progress * working on getting a basic test to work * basic standard form validation * adding fixtures * more basic completion check * shelving progress * I want to keep record of this, but it will change. * mid-refactor, but time for guitar lessons * one last quick checkin * I've got 99 problems and all of them are async * commenting out broken tests, fixing async * started creation of required schema * updating fixture to fail, removing review/submit * new form test * new completion function * now with modals * Some changes and empty plan fixture * params for fixture testing * resolved test, renamed functions * extracting completion check into it's own file * extracted code into seperate file * adding conditional calculation to fetch * resolving issue with new reports * cleaning up testing fixtures * adding comments --------- Co-authored-by: Thomas Blackwell <thomas.blackwell@coforma.io> Co-authored-by: Karla Valcárcel Martínez <99458559+karla-vm@users.noreply.github.com>
oweingrod-coforma
added a commit
that referenced
this pull request
Mar 22, 2023
* Cypress fix2 (#11081) * cypress fix and version bump * updating audit version, disabling pa11y on local * pre-commit action dislikes this. * MDCT-2264: Create S3 Buckets + DynamoDB Table for MLR (#11079) * adding MLR resources * indentation and reference fix * serverless fix * how about I actually fix it * duplicate removal * naaar tables and form buckets (#11087) * Clean up reporting APIs. (#11082) * Add new error constants for Dynamo errors Error constants nerw constant * Refactor reports/create.ts to handle errors more cleanly Fix create route * Refactor reports/archive.ts to handle errors more cleanly Archive test should be calling `archive` route. Previously, tests were calling `update` route. * Refactor reports/fetch.ts to handle errors more cleanly * Missing a required argument should return a `400` not a `500`. Update test asserts to expect new status codes and error messages. * Refactor reports/update.ts to handle errors more clearly Reorganize code to move returned errors closer to their conditional checks. Adds additional error handling for S3 and Dynamo, and removes (likely) un-needed logic to archive reports from this route. Remove duplicate `update` test. * Archive route should ensure credentials * Fetch handler was looking for wrong path parameter * Add new discrete handler for archiving reports. * Point archive button to the archive handler Instead of the update handler * Statusing completeness checker (#11095) * shelving progress * working on getting a basic test to work * basic standard form validation * adding fixtures * more basic completion check * shelving progress * I want to keep record of this, but it will change. * mid-refactor, but time for guitar lessons * one last quick checkin * I've got 99 problems and all of them are async * commenting out broken tests, fixing async * started creation of required schema * updating fixture to fail, removing review/submit * new form test * new completion function * now with modals * Some changes and empty plan fixture * params for fixture testing * resolved test, renamed functions * extracting completion check into it's own file * extracted code into seperate file * adding conditional calculation to fetch * resolving issue with new reports * cleaning up testing fixtures * adding comments --------- Co-authored-by: Thomas Blackwell <thomas.blackwell@coforma.io> Co-authored-by: Karla Valcárcel Martínez <99458559+karla-vm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Disabling pa11y on local testing. This is because node 18 doesn't play well with
localhoston our machines. pa11y tests still execute correctly in CIRelated ticket
N/A
How to test
Execute accessibility cypress tests, they should now succeed
Important updates
yarn in tests/cypress to pick up version bump on pa11y library
Author checklist
I have added thorough tests, if necessaryI have updated the documentation, if necessary