Fix template download #11599
Merged
Fix template download #11599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmrabian
requested review from
BearHanded,
braxex and
karla-vm
as code owners
gmrabian
requested review from
berryd,
ajaitasaini,
keeysnc,
ntsummers1,
britt-mo,
dwhitestratiform,
benmartin-coforma and
ailZhou
berryd
approved these changes
Feb 26, 2024
|
Code Climate has analyzed commit 83b6545 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
karla-vm
approved these changes
Feb 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The presigned URL call was missing the await it needed to get a value from the s3-lib. Now the
awaitis there!Related ticket(s)
CMDCT-3334
How to test
(MLR and NAAAR files are not in this branch so those will error)
Author checklist