Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMDCT-3399: PDF Text Overflow (Bug) #11623

Merged
merged 1 commit into from
Mar 12, 2024
Merged

CMDCT-3399: PDF Text Overflow (Bug) #11623

merged 1 commit into from
Mar 12, 2024

Conversation

karla-vm
Copy link
Collaborator

Description

Currently, in the production environment, there is a text overflow happening that's causing accessibility and readability issues. Adding a maxWidth will hopefully fix that.

Screenshot 2024-03-12 at 11 36 17 AM

Related ticket(s)

CMDCT-3399


How to test

This issue is not happening in main or val, unfortunately, so we can't replicate it or validate until the fix is up in prod

Important updates


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

Copy link

codeclimate bot commented Mar 12, 2024

Code Climate has analyzed commit 98f8d00 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@keeysnc keeysnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this should work.

@karla-vm karla-vm merged commit b28407f into main Mar 12, 2024
19 checks passed
@karla-vm karla-vm deleted the pdf-3399 branch March 12, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants