Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding additional slack capabilities to mcr #11674

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

dwhitestratiform
Copy link
Contributor

Description

Trying to fill in some gaps from the slack implementation this PR does a couple of things

when snyk opens a pr now we alert on failing pr checks, prior we were only alerting on failed deploy/tests from a failed snyk auto merge. This should cover all the failing scenarios for Snyk now.

when a pr is opened the cloudfront URL is added to the slack notification in the integrations channel

I opted not to add alerts in for from red to green builds because it started getting very custom and although nice to have, not a must have.

Related ticket(s)

CMDCT-3534


How to test

create a pull request and see your cloudfront url in the integrations channel
I tested the failed pr notification in the core repo where we were seeing a failed pr step on a snyk build here

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

Copy link

codeclimate bot commented Apr 19, 2024

Code Climate has analyzed commit 55b7c29 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.0% change).

View more on Code Climate.

@dwhitestratiform dwhitestratiform merged commit f628848 into main Apr 19, 2024
19 checks passed
@dwhitestratiform dwhitestratiform deleted the slack-follow-on branch April 19, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants