adding additional slack capabilities to mcr #11674
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to fill in some gaps from the slack implementation this PR does a couple of things
when snyk opens a pr now we alert on failing pr checks, prior we were only alerting on failed deploy/tests from a failed snyk auto merge. This should cover all the failing scenarios for Snyk now.
when a pr is opened the cloudfront URL is added to the slack notification in the integrations channel
I opted not to add alerts in for from red to green builds because it started getting very custom and although nice to have, not a must have.
Related ticket(s)
CMDCT-3534
How to test
create a pull request and see your cloudfront url in the integrations channel
I tested the failed pr notification in the core repo where we were seeing a failed pr step on a snyk build here
Notes
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod