Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump action versions #11679

Merged
merged 2 commits into from
May 3, 2024
Merged

Bump action versions #11679

merged 2 commits into from
May 3, 2024

Conversation

gmrabian
Copy link
Contributor

Description

The code-climate action we use recently had an upgrade to node 20. That was one of the lingering Node 16 actions across our apps so I'm taking this opportunity to bump actions across our apps.

Related ticket(s)

CMDCT-3577


How to test

All actions pass and there are no warnings about Node 16 actions! 馃帀

Notes

No code changes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

@gmrabian gmrabian changed the title bump action versions Bump action versions Apr 29, 2024
Copy link
Collaborator

@karla-vm karla-vm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some failing E2E tests 'cause they're flaky, but we can re-run them until they pass.

@gmrabian gmrabian added the ready for review Ready for all the reviews! label May 3, 2024
Copy link

codeclimate bot commented May 3, 2024

Code Climate has analyzed commit 9283fc5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.0% change).

View more on Code Climate.

@gmrabian gmrabian merged commit b1dfc5d into main May 3, 2024
19 checks passed
@gmrabian gmrabian deleted the action-version-bumps branch May 3, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
3 participants