Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMDCT-3543: ILOS (Section A. Program Information) #11682

Merged
merged 9 commits into from
May 6, 2024
Merged

Conversation

karla-vm
Copy link
Collaborator

@karla-vm karla-vm commented May 3, 2024

Description

This PR adds a new subsection of Section A. Program Information of the MCPAR report, which includes a new form which is a dynamic field (similar to Add plans) for ILOS entities.

Related ticket(s)

CMDCT-3544


How to test

  • Log in as a state user
  • Create a new MCPAR report
  • Navigate to /mcpar/program-information/add-in-lieu-of-services
  • Verify the functionality stated above (as well as the correct completion status in Review & submit).

Notes

mcpar.json is updated to include a new section under Section A. Program Information titled Add In Lieu of Services


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

@karla-vm karla-vm marked this pull request as ready for review May 3, 2024 18:17
@karla-vm karla-vm marked this pull request as draft May 3, 2024 20:02
@karla-vm karla-vm changed the title [POC] ILOS CMDCT-3543: ILOS (Section A. Program Information + Section D.) May 6, 2024
@karla-vm karla-vm marked this pull request as ready for review May 6, 2024 13:12
Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw some funky behavior when deleting ILOS entries. Whereas the page was previously marked optional, and didn't trigger an error on Review and Submit when blank, it was marked as Error if I created and then deleted entries. Additionally the section D page didn't reset to the no-entries state where it indicates where I can go to enter them.

Maybe related to this being our first non-required entity? Plans reset as expected on each page

Screen.Recording.2024-05-06.at.9.42.13.AM.mov

@karla-vm karla-vm changed the title CMDCT-3543: ILOS (Section A. Program Information + Section D.) CMDCT-3543: ILOS (Section A. Program Information) May 6, 2024
@karla-vm
Copy link
Collaborator Author

karla-vm commented May 6, 2024

I saw some funky behavior when deleting ILOS entries. Whereas the page was previously marked optional, and didn't trigger an error on Review and Submit when blank, it was marked as Error if I created and then deleted entries. Additionally the section D page didn't reset to the no-entries state where it indicates where I can go to enter them.

Maybe related to this being our first non-required entity? Plans reset as expected on each page

Screen.Recording.2024-05-06.at.9.42.13.AM.mov

Great catch, Garrett!
The schema in app-api wasn't validating dynamicOptional fields correctly, so I've updated it to match the ui-src schema, that should fix the issue you saw in the Review & submit page. I also narrowed down the scope of this PR by removing the Section D. form for now, I'm still having a couple of conversations with Design + Product about that.

Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last thing :)

services/app-api/forms/mcpar.json Outdated Show resolved Hide resolved
@karla-vm karla-vm enabled auto-merge (squash) May 6, 2024 16:00
Copy link

codeclimate bot commented May 6, 2024

Code Climate has analyzed commit 00ccdc4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.0% change).

View more on Code Climate.

@karla-vm karla-vm merged commit b4b0370 into main May 6, 2024
19 checks passed
@karla-vm karla-vm deleted the ilos-poc-2543 branch May 6, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants