-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMDCT-3543: ILOS (Section A. Program Information) #11682
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw some funky behavior when deleting ILOS entries. Whereas the page was previously marked optional, and didn't trigger an error on Review and Submit when blank, it was marked as Error if I created and then deleted entries. Additionally the section D page didn't reset to the no-entries state where it indicates where I can go to enter them.
Maybe related to this being our first non-required entity? Plans reset as expected on each page
Screen.Recording.2024-05-06.at.9.42.13.AM.mov
Great catch, Garrett! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last thing :)
Code Climate has analyzed commit 00ccdc4 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 95.9% (0.0% change). View more on Code Climate. |
Description
This PR adds a new subsection of
Section A. Program Information
of the MCPAR report, which includes a new form which is a dynamic field (similar toAdd plans
) for ILOS entities.Related ticket(s)
CMDCT-3544
How to test
/mcpar/program-information/add-in-lieu-of-services
Review & submit
).Notes
mcpar.json
is updated to include a new section underSection A. Program Information
titledAdd In Lieu of Services
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod