Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MCR to Node 20 #11683

Merged
merged 3 commits into from
May 7, 2024
Merged

Upgrade MCR to Node 20 #11683

merged 3 commits into from
May 7, 2024

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented May 6, 2024

Description

  • Upgrade .nvmrc to node 20
  • Upgrade services to node 20
  • Upgrade dependencies that need it for compatability
  • Remove redundant dependencies

Note: there are three lambdas that aren't on Node 20. Two of them are created by serverless to link resources as a workaround for...itself. The other one is created by the warmup plugin. The warmup one will likely be removed when we migrate to serverless compose, and the serverless ones we have no control over. We might be able to narrow down where they come from with an infrastructure audit, but it just runs once on deploy and then sits there. It'll only be a concern if AWS removes support for Node16, and in that case everyone using serverless will need a solution, so they should upgrade it by then (right...?)

Related ticket(s)

CMDCT-2656


How to test

Deployed url: https://d20ag9emgh3qad.cloudfront.net/
Everything works as expected
Lambdas don't fail


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

@gmrabian gmrabian changed the title Cmdct 2656 Upgrade MCR to Node 20 May 6, 2024
Copy link

codeclimate bot commented May 6, 2024

Code Climate has analyzed commit 3679b07 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 96.0% (0.0% change).

View more on Code Climate.

@gmrabian gmrabian marked this pull request as ready for review May 6, 2024 20:00
@gmrabian gmrabian added the ready for review Ready for all the reviews! label May 6, 2024
Copy link
Collaborator

@karla-vm karla-vm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in the deployed instance, everything looks good!

@gmrabian gmrabian merged commit fd40b53 into main May 7, 2024
23 checks passed
@gmrabian gmrabian deleted the cmdct-2656 branch May 7, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
3 participants