Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All of our applications have been leaking infrastructure due to the reliability of the destroy mechanism. In the past it's been a rather manual process to clean up latent and orphaned infrastructure in order to keep account costs under control. Luckily, our ephemeral environments and very light weight and cheap to operate, but manually cleaning up orphaned infrastructure doesn't scale.
The purpose of this PR is retrofit an existing solution into MCR. We have already seen this working in QMR.
Notable changes:
./run local
is equivalent to prior functionality./run destroy --stage [stage]
Related ticket(s)
CMDCT-3640
How to test
Evidence of this successfully executing can be seen here
(It failed on the first try but then passed on re-run, so something to watch out for. I think QMR, SEDS, and CARTS all passed on the first time. I ran it again against a different branch just to see and it passed the first time.)
Pre-review checklist
[ ] I have added thorough tests, if necessary