Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMDCT-3657 - swap react-scripts to vite #11702

Merged
merged 2 commits into from
May 21, 2024
Merged

CMDCT-3657 - swap react-scripts to vite #11702

merged 2 commits into from
May 21, 2024

Conversation

BearHanded
Copy link
Contributor

@BearHanded BearHanded commented May 21, 2024

Description

Following this guide + Lessons learned from the Enterprise-CMCS/macpro-mdct-carts#139627.

Unique changes in this app vs CARTS.

  • Re-include jest that came with react scripts

Related ticket(s)

CMDCT-3657


How to test

Run locally
Run jest locally
Test deployed env, look for missing resources or odd interactions from included packages
https://dcwnzb1fyc8s.cloudfront.net/

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6236 lines exceeds the maximum allowed for the inline comments feature.

Copy link

codeclimate bot commented May 21, 2024

Code Climate has analyzed commit 038c45a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.0% change).

View more on Code Climate.

@BearHanded BearHanded marked this pull request as ready for review May 21, 2024 12:46
@BearHanded BearHanded changed the title swap react-scripts to vite CMDCT-3657 - swap react-scripts to vite May 21, 2024
Copy link
Collaborator

@karla-vm karla-vm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing an issue with downloading the MCPAR and MLR templates on the landing page:

MCPAR template download
Screenshot 2024-05-21 at 9 25 17 AM

MLR template download
Screenshot 2024-05-21 at 9 25 55 AM

Not sure if that's related to the vite update.

@BearHanded
Copy link
Contributor Author

I believe that is just the template file not being manually uploaded to the deployed branch. The same error appears on other ephem branches.

@BearHanded BearHanded merged commit 6f75db1 into main May 21, 2024
21 checks passed
@BearHanded BearHanded deleted the vite branch May 21, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants