-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMDCT-3657 - swap react-scripts to vite #11702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 6236 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit 038c45a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 95.9% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that is just the template file not being manually uploaded to the deployed branch. The same error appears on other ephem branches. |
Description
Following this guide + Lessons learned from the Enterprise-CMCS/macpro-mdct-carts#139627.
Unique changes in this app vs CARTS.
Related ticket(s)
CMDCT-3657
How to test
Run locally
Run jest locally
Test deployed env, look for missing resources or odd interactions from included packages
https://dcwnzb1fyc8s.cloudfront.net/
Notes
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod