Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E2E Logic #11709

Closed
wants to merge 6 commits into from
Closed

Fix E2E Logic #11709

wants to merge 6 commits into from

Conversation

karla-vm
Copy link
Collaborator

Description

Logic was incorrect in earlier form.cy.js update.

Related ticket(s)

N/A


How to test

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

gmrabian
gmrabian previously approved these changes May 21, 2024
@karla-vm karla-vm enabled auto-merge (squash) May 21, 2024 21:00
Copy link

codeclimate bot commented May 21, 2024

Code Climate has analyzed commit 498e55f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.0% change).

View more on Code Climate.

@karla-vm karla-vm closed this May 22, 2024
auto-merge was automatically disabled May 22, 2024 13:41

Pull request was closed

@karla-vm karla-vm deleted the fix-logic branch May 22, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants