-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ILOS (I Lose ollmy Sanity) #11710
Merged
Merged
ILOS (I Lose ollmy Sanity) #11710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmrabian
previously approved these changes
May 22, 2024
Co-authored-by: benmartin-coforma <126210497+benmartin-coforma@users.noreply.github.com>
…ert cypress changesrevert cypress changesrevert cypress changesrevert cypress changesrevert cypress changesrevert cypress changes
gmrabian
previously approved these changes
May 22, 2024
Code Climate has analyzed commit 9c2f638 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 95.9% (0.0% change). View more on Code Climate. |
gmrabian
approved these changes
May 22, 2024
jessabean
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because of how we handle the form templates in MCR, hiding a route behind a feature flag on the frontend doesn't actually cover any completion status problems, so this PR handles the ILOS requirement a bit more cleanly:
If the ILOS feature flag is enabled, the form template will include ILOS fields. If that feature flag is disabled, then it won't.
Related ticket(s)
N/A
How to test
In this deployed instance or locally, you should still see the ILOS fields for MCPAR. If you hardcode
ilosAvailable
tofalse
here those sections won't be there 🪄Notes
N/A
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod