Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILOS (I Lose ollmy Sanity) #11710

Merged
merged 13 commits into from
May 22, 2024
Merged

ILOS (I Lose ollmy Sanity) #11710

merged 13 commits into from
May 22, 2024

Conversation

karla-vm
Copy link
Collaborator

Description

Because of how we handle the form templates in MCR, hiding a route behind a feature flag on the frontend doesn't actually cover any completion status problems, so this PR handles the ILOS requirement a bit more cleanly:

If the ILOS feature flag is enabled, the form template will include ILOS fields. If that feature flag is disabled, then it won't.

Related ticket(s)

N/A


How to test

In this deployed instance or locally, you should still see the ILOS fields for MCPAR. If you hardcode ilosAvailable to false here those sections won't be there 🪄

Notes

N/A


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

gmrabian
gmrabian previously approved these changes May 22, 2024
services/ui-src/src/utils/forms/ilosFields.ts Outdated Show resolved Hide resolved
karla-vm and others added 2 commits May 22, 2024 13:01
Co-authored-by: benmartin-coforma <126210497+benmartin-coforma@users.noreply.github.com>
…ert cypress changesrevert cypress changesrevert cypress changesrevert cypress changesrevert cypress changesrevert cypress changes
gmrabian
gmrabian previously approved these changes May 22, 2024
Copy link

codeclimate bot commented May 22, 2024

Code Climate has analyzed commit 9c2f638 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.0% change).

View more on Code Climate.

@karla-vm karla-vm merged commit c11ca75 into main May 22, 2024
19 checks passed
@karla-vm karla-vm deleted the ilos-ld-deux branch May 22, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants