Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code and dependencies in uploads #11717

Merged
merged 1 commit into from
May 28, 2024
Merged

Remove unused code and dependencies in uploads #11717

merged 1 commit into from
May 28, 2024

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented May 24, 2024

Description

  • Remove all unreferenced dependencies
  • Upgrade serverless-s3-local to latest, removing old aws-sdk 2 sub-dependency
  • Remove unused api, scan, and test.json files

How to test

  • Virus scan works in deployed env: https://d3g5rqdomzar9t.cloudfront.net/
  • Template downloads still work in the deployed env
  • No new lambda errors in upload lambdas
    • I tested with our templates and with empty test files. All came back clean, no errors
      • You can check the uploads-clean-uploads-attachments-* bucket in AWS to verify the files are tagged clean
      • You can check the uploads-clean-uploads-avscan lambda logs to verify everything works
  • Local run works

Copy link

codeclimate bot commented May 24, 2024

Code Climate has analyzed commit 1004e7f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.0% change).

View more on Code Climate.

@gmrabian gmrabian marked this pull request as ready for review May 28, 2024 13:09
@gmrabian gmrabian added the ready for review Ready for all the reviews! label May 28, 2024
Copy link
Collaborator

@karla-vm karla-vm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love a good cleanup!

@gmrabian gmrabian merged commit b5109d6 into main May 28, 2024
23 checks passed
@gmrabian gmrabian deleted the clean-uploads branch May 28, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
2 participants