Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMDCT-3172] Convert EntityProvider to Zustand #11718

Merged
merged 9 commits into from
May 31, 2024
Merged

[CMDCT-3172] Convert EntityProvider to Zustand #11718

merged 9 commits into from
May 31, 2024

Conversation

karla-vm
Copy link
Collaborator

Description

This covers the last part of our ✨ #mcrZustandification ✨ by converting the EntityProvider to Zustand. Some of these changes include refactoring decisions that were made while building out MFP.

Related ticket(s)

CMDCT-3172


How to test

There should be no changes in terms of functionality, so to test this, you should go through a MCPAR and MLR reports and be able to submit without any problems w/ entities.

Notes

N/A


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

gmrabian
gmrabian previously approved these changes May 29, 2024
Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@karla-vm karla-vm requested a review from gmrabian May 31, 2024 13:21
jessabean
jessabean previously approved these changes May 31, 2024
Copy link

@jessabean jessabean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

codeclimate bot commented May 31, 2024

Code Climate has analyzed commit 930015e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 85.7% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.8% (-0.1% change).

View more on Code Climate.

@BearHanded BearHanded merged commit 553ab50 into main May 31, 2024
17 of 19 checks passed
@BearHanded BearHanded deleted the zustand-3172 branch May 31, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants