Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused URL env variable #11722

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Remove unused URL env variable #11722

merged 1 commit into from
Jun 6, 2024

Conversation

bangbay-bluetiger
Copy link
Contributor

@bangbay-bluetiger bangbay-bluetiger commented Jun 5, 2024

Description

  • Remove URL env from template. It isn't referenced anywhere in the codebase.
  • Remove pragma comments when running ./run update-env or ./run local --update-env.

How to test

  1. Run ./run local --update-dev to update your local .env and start MCR
  2. Verify there are no pragma comments in .env
  3. Verify MCR works as normal
  4. Run ./run update-env and verify there are no pragma comments in .env

Notes

URL env variable is also defined in MFP and CARTS and appears unused.

Copy link

codeclimate bot commented Jun 5, 2024

Code Climate has analyzed commit da38523 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.8%.

View more on Code Climate.

@bangbay-bluetiger bangbay-bluetiger merged commit cbc56bb into main Jun 6, 2024
23 checks passed
@bangbay-bluetiger bangbay-bluetiger deleted the bs-remove-url-env branch June 6, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants