-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge val → prod #3159
Merged
Merged
merge val → prod #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layout cleanup
* make report layout * make tests pass * leave form button works * modify test
* create form factory * a little cleanup * split out Form and add tests * convert validation schema to json * fix failing test * Form handles form field factory rendering * focus errors poc * fix id/name issues and handle failing child fields * fix description in similar fashion * cleanup * tweak * actually fix things * manual revert i guess. idk at this point * ok everything is actually fixed * move method to utils * fix failing e2e test * add unit tests * lol what why? * ah ok * convert validation schema to json (#3001) * convert validation schema to json * fix failing test * Form handles form field factory rendering * one straggler
…3062) * merge in main * fix form storage * build out 'point of contact' form * tweak * add unit test * how about this? * ok * add dynamic routing * name change * oops missed one * add unit tests * fix login page
* merge in main * fix form storage * build out 'point of contact' form * tweak * add unit test * how about this? * ok * add dynamic routing * name change * oops missed one * add unit tests * fix login page * solve hydration
* merge in main * fix form storage * build out 'point of contact' form * tweak * add unit test * how about this? * ok * add dynamic routing * name change * oops missed one * add unit tests * fix login page * solve hydration * remove need for duplicate name/id
* wip sidebar * add chakra link * wip sidenav * cleanup * further cleanup * dropdowns work for A and B * styling * structure * lol had some stuff backwards * another tweak * another tweak * add select styling and rest of options * cleanup * move out sidenav items * add arrow switching * naming updates * fix up unit tests * good enough to take to design * yet a bit better * maybe this * ok how about this now Co-authored-by: Braxton Excell <braxton.excell@gmail.com>
merge dev → val
Co-authored-by: Brax Excell <braxton.excell@gmail.com>
Fix view shift for tablet and desktop
* Update cmsds * Buggy but slightly working updated datefield cmpnt * Alpha Example of Datefield * Get validation working for admin banner * Update tests * fixes for nick * Swap back to number inputs for datefield * Move useState to first import line * Fix e2e test * Fix e2e test * Fix e2e test * Fix e2e test * Fix e2e test Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Braxton Excell <braxton.excell@gmail.com>
…ield value onChange (#3096) * Setup env for testing Choicelist * Fix value output for Choicelist * Fix checkbox styling * Keep Example Env Open * Fix radio button output + remove disabled and default check * Add more tests to choicelist component * Split up checkbox and radio to own form components * Cleanup outputs for radio and checkbox fields * Move styling fix for checkboxs to component file * Attempting to fix onChangeHandler for checkbox * Update checkbox and radio field tests * Add back errorhandling Co-authored-by: Nicholas Summers <nick@coforma.io>
* merge in main * fix form storage * build out 'point of contact' form * tweak * add unit test * how about this? * ok * add dynamic routing * name change * oops missed one * add unit tests * fix login page * solve hydration * not really sure * nesting actually working? * add conditional styling * it works which is cool * a little extra work to see about double-nesting * stopping point * tweaks * fix failing tests * move child handling to ChoiceList * fix up nested styling * fix tests, etc. * how about this code climate? * some more tests"
* fix field registration and validation * fix failing tests * updates * convert admin banner * remove validation from other forms * configure validation for test form * fix tests * return to /test * update reporting period form * update checkbox style * add radio to test file
merge dev → val
Removes sidebar status icon, aligns sidebar text with header
* Update profile page for MCR * Adds light test for profile page * Fix text formatting for tests and add a couple more * Fix margin bottom + link formatting on profile page Co-authored-by: Nicholas Summers <nick@coforma.io>
* Add validation to Datefields * Swap datefield to text validation * Pull out datetime conversion to seperate file * time-focused stuff * modify onChangeHandler * get both regex and min test validation working * fix failing tests * fix controlled/uncontrolled issue * oops -- add matcher back in lol * Add in a couple more tests for Datefield * Fix typo in datefield schema * Remove lacking hydrate test from Datefield Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Braxton Excell <braxton.excell@gmail.com>
* groundwork * stopping point * get report creation working * reconfigure basepath stuff * report vs form nomenclature * flatten array routes * remove old sidenav structure * fix up redirects and element rendering * fix some tests * add tests * better types yay
merge main → val
* add mcpar pagejson, formjson, schema * add other pages and tune up
merge main → val
ntsummers1
approved these changes
Jul 21, 2022
gmrabian
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge val → prod (end of sprint)