-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge val → prod #3711
Merged
Merged
merge val → prod #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add deleteReport * change key names * add deleteReport tests * cleanup and change authorized user * add deleteReportData and tests * combine deleteReportData into deleteReport * remove unnecessary code
* display plan types * open drawer from report * the entity is now state * cannot save because drawer Co-authored-by: juliuscaesar <caesarnuzzolo@Caesars-MBP.lan>
Co-authored-by: Nicholas Summers <nick@coforma.io>
Co-authored-by: Nicholas Summers <nick@coforma.io>
* Add percentage fields * Add percentage field tests * Add percentage fields to those who need it Co-authored-by: Nicholas Summers <nick@coforma.io>
* Focus elements like no one else has before * Ensure correct order of fields to focus on * Fix sortFormErrors Test * Fix up scrollIntoView breaking tests Co-authored-by: Nicholas Summers <nick@coforma.io>
* stopping point * push please * trying again * wip don't judge * cleanup * more cleanup * cleanup * clean up dashboard with modals * get all dashboard working * remove formviewprovider * extract reportsByState * one test to fix * add test * tests for modals * add dashboard tests * final cleanup * add mock * add mock for error * add missing mocks Co-authored-by: Garrett Rabian <garrett@coforma.io> Co-authored-by: Garrett <57802560+gmrabian@users.noreply.github.com>
MCR Main -> Val
braxex
requested review from
karla-vm,
TheDanMiller,
BearHanded,
bodnarbm,
gmrabian,
ntsummers1 and
juliuscaesar
as code owners
August 31, 2022 20:36
gmrabian
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge val → prod