renamed ReportPage types #4201
Merged
renamed ReportPage types #4201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braxex
requested review from
karla-vm,
TheDanMiller,
BearHanded,
gmrabian,
ntsummers1,
juliuscaesar,
scwambach and
britt-mo
as code owners
ntsummers1
approved these changes
Oct 4, 2022
gmrabian
approved these changes
Oct 4, 2022
karla-vm
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per discussion with the team, renamed:
EntityDrawerReportPage→DrawerReportPageDynamicDrawerReportPage→ModalDrawerReportPageHow to test
All tests pass. No functionality changed.
Changed Dependencies
n/a
Code author checklist
I have added thorough testsI have added analytics, if necessaryI have updated the documentation, if necessaryReviewer checklist (two different people)