added spreadsheet widgets #4248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scwambach
requested review from
karla-vm,
TheDanMiller,
BearHanded,
braxex,
gmrabian,
ntsummers1,
juliuscaesar and
britt-mo
as code owners
gmrabian
approved these changes
Oct 6, 2022
gmrabian
approved these changes
Oct 6, 2022
braxex
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
All looks good to me. I would like to push back on design before merging though as to why have spreadsheet first in some cases and last in others. Seems like it might be a mistake on their part and if so, and we don't have to build out this functionality that's all the better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added spreadsheet widgets where they needed to go, plus an additional option to allow the spreadsheet widget to be last in the intro.
How to test
check through sections A and B
Changed Dependencies
Code author checklist
Reviewer checklist (two different people)