Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDCT-2016: Section C Redlines #4253

Merged
merged 11 commits into from
Oct 11, 2022
Merged

MDCT-2016: Section C Redlines #4253

merged 11 commits into from
Oct 11, 2022

Conversation

ntsummers1
Copy link
Contributor

Description

Full list of changes here: MDCT-2016

How to test

./dev local
Load up a program
Checkout section C!

Changed Dependencies

Code author checklist

  • I have performed a self-review of my code
  • I have added thorough tests
  • I have added analytics, if necessary
  • I have updated the documentation, if necessary

Reviewer checklist (two different people)

  • I have done the deep review and verified the items in the above checklist are g2g
  • I have done the lgtm review

braxex
braxex previously requested changes Oct 6, 2022
Copy link
Contributor

@braxex braxex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a couple changes requested.

services/ui-src/src/forms/mcpar/mcpar.json Show resolved Hide resolved
services/ui-src/src/forms/mcpar/mcpar.json Outdated Show resolved Hide resolved
@ntsummers1
Copy link
Contributor Author

Approved by Kim!

@ntsummers1 ntsummers1 merged commit 0480598 into main Oct 11, 2022
@ntsummers1 ntsummers1 deleted the mdct-2016 branch October 11, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants