Admin Banner: accept valid 404 use case #4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmrabian
requested review from
karla-vm,
TheDanMiller,
BearHanded,
braxex,
ntsummers1,
juliuscaesar,
scwambach and
britt-mo
as code owners
scwambach
approved these changes
Oct 7, 2022
britt-mo
approved these changes
Oct 7, 2022
braxex
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the admin banner page was displaying an error message when there was no existing banner to be fetched. Since 404 is a valid case for no banner existing, we will ignore it for now.
Future considerations: change the banner api to allow multiple banners and fetch multiple, displaying those relevant to the current date
How to test
login as admin
go to /admin
see if banner goes away for 404 and still shows up for 500s
Code author checklist
Reviewer checklist (two different people)