Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize entity card per type #4336

Merged
merged 8 commits into from
Oct 12, 2022
Merged

Customize entity card per type #4336

merged 8 commits into from
Oct 12, 2022

Conversation

gmrabian
Copy link
Contributor

Description

Abstract the logic for entity cards so it's a little easier to create a display that matches each type

How to test

Access measures entity cards work as normal

Code author checklist

  • I have performed a self-review of my code
  • I have added thorough tests
  • I have added analytics, if necessary
  • I have updated the documentation, if necessary

Reviewer checklist (two different people)

  • I have done the deep review and verified the items in the above checklist are g2g
  • I have done the lgtm review

braxex
braxex approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@braxex braxex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner -- thank you.

Left a few comments but nothing blocking.

services/ui-src/src/types/index.ts Show resolved Hide resolved
services/ui-src/src/components/index.ts Outdated Show resolved Hide resolved
services/ui-src/src/components/cards/EntityCard/EntityCardBottomText.tsx Outdated Show resolved Hide resolved
services/ui-src/src/components/cards/EntityCard/EntityCardBottomText.tsx Outdated Show resolved Hide resolved
@gmrabian gmrabian marked this pull request as ready for review October 12, 2022 13:31
@ntsummers1 ntsummers1 self-requested a review October 12, 2022 16:15
@braxex
Copy link
Contributor

braxex commented Oct 12, 2022

@gmrabian Looks great. 🚢 it

@gmrabian gmrabian merged commit 5b7ed80 into main Oct 12, 2022
@gmrabian gmrabian deleted the custom-entity-card branch October 12, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braxex braxex braxex approved these changes

@ntsummers1 ntsummers1 ntsummers1 approved these changes

@karla-vm karla-vm Awaiting requested review from karla-vm karla-vm is a code owner

@TheDanMiller TheDanMiller Awaiting requested review from TheDanMiller

@BearHanded BearHanded Awaiting requested review from BearHanded BearHanded is a code owner

@juliuscaesar juliuscaesar Awaiting requested review from juliuscaesar

@scwambach scwambach Awaiting requested review from scwambach

@britt-mo britt-mo Awaiting requested review from britt-mo

Assignees

@gmrabian gmrabian

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@gmrabian @braxex @ntsummers1