Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDCT-2027: Scotts Great Ampersand #4346

Merged
merged 4 commits into from
Oct 12, 2022
Merged

MDCT-2027: Scotts Great Ampersand #4346

merged 4 commits into from
Oct 12, 2022

Conversation

ntsummers1
Copy link
Contributor

Description

For the mad genius himself

Fixes MDCT-2027

How to test

./dev local
Look at literally everything. Holy moly did I delete some code

Changed Dependencies

Code author checklist

  • I have performed a self-review of my code
  • I have added thorough tests
  • I have added analytics, if necessary
  • I have updated the documentation, if necessary

Reviewer checklist (two different people)

  • I have done the deep review and verified the items in the above checklist are g2g
  • I have done the lgtm review

@ntsummers1 ntsummers1 changed the title MDCT-2027: Scotts Great ~~escape~~Ampersand MDCT-2027: Scotts Great Ampersand Oct 12, 2022
braxex
braxex approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@braxex braxex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing ✨

services/ui-src/src/components/fields/CheckboxField.tsx Outdated Show resolved Hide resolved
services/ui-src/src/components/menus/Sidebar.tsx Outdated Show resolved Hide resolved
Nick Summers and others added 2 commits October 12, 2022 09:28
@braxex
Update services/ui-src/src/components/fields/CheckboxField.tsx
3762044 
Co-authored-by: Brax Excell <braxton@coforma.io>
@braxex
Update services/ui-src/src/components/menus/Sidebar.tsx
bd6db7c 
Co-authored-by: Brax Excell <braxton@coforma.io>
@ntsummers1 ntsummers1 marked this pull request as ready for review October 12, 2022 13:28
gmrabian
gmrabian approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class struggle is over! All media classes are now recognized at the top level. We have won! In the immortal words of Karl Marx: "Das ist gut"

@ntsummers1 ntsummers1 merged commit 62f1a6f into main Oct 12, 2022
@ntsummers1 ntsummers1 deleted the mdct-2027 branch October 12, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braxex braxex braxex approved these changes

@gmrabian gmrabian gmrabian approved these changes

@karla-vm karla-vm Awaiting requested review from karla-vm karla-vm is a code owner

@TheDanMiller TheDanMiller Awaiting requested review from TheDanMiller

@BearHanded BearHanded Awaiting requested review from BearHanded BearHanded is a code owner

@juliuscaesar juliuscaesar Awaiting requested review from juliuscaesar

@scwambach scwambach Awaiting requested review from scwambach

@britt-mo britt-mo Awaiting requested review from britt-mo

Assignees

@ntsummers1 ntsummers1

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ntsummers1 @braxex @gmrabian