Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drawer hydration shape #4376

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Fix drawer hydration shape #4376

merged 3 commits into from
Oct 12, 2022

Conversation

gmrabian
Copy link
Contributor

Description

This was nested under fieldData but we need it at the top level

How to test

Go the the access measures page and see it hydrates

Code author checklist

  • I have performed a self-review of my code
  • I have added thorough tests
  • I have added analytics, if necessary
  • I have updated the documentation, if necessary

Reviewer checklist (two different people)

  • I have done the deep review and verified the items in the above checklist are g2g
  • I have done the lgtm review

Copy link
Contributor

@braxex braxex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird. i thought we fixed this already... 🤔

@gmrabian gmrabian merged commit 18e42a0 into main Oct 12, 2022
@gmrabian gmrabian deleted the fix-drawer-hydration branch October 12, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants