-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Val #5177
Merged
Merged
Val #5177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip * clean start * wip * see if it runs * reused sanitize functions * remove logs * cleanup * add fallback * test update * scan iteration * need routing change * documentation and modularity * test changes in pipeline * log * more logs * try more waiting * i don't get it * I silly * try outputting old stufF * nvm * promises are for liars * throw async out the window? * forEach can't async * ಠ_ಠ * cleanup * make db changeable Co-authored-by: Scott Wambach <scott@scottwamba.ch> Co-authored-by: brendan <brendan@coforma.io>
* removing feature files and adding video upload * adding admin feature back * as of cypress 8.0 headless not needed (default) * adding back in the mcpar features * updating cypress version. * adjusting retry/timeout variables * extending timeout * removing mcpar * back up to 20 seconds. * optimistically uncommenting tests Co-authored-by: Nick Summers <ntsummers1@gmail.com>
* launching launchdarkly in the dark * And the React SDK * removing JS SDK * testing a new flag * GH Actions + env example * update env file * adding a new workflow * remove action.yml file * update deploy workflow * take THIS * let's see * seein' some things * testing that sweet launch darkly setup * Removing flags from components + env file * removing node SDK * setting up ld * remove LD code references check * removing key from env_example
* Adding dynamic form fill for MCPAR * commenting out existing and merging into 1 file
* add axios to api * more descriptive errors * remove extra line
Create MCPAR Form Buckets
* Adding env example for new s3 bucket * Updating correct example this time.
Fix formatting on codeowners file
Update bucket folders to new scheme
* put button on page * update preview route * keep print stuff in intro * Mdct 2102 - PDF: Preview Page setup (#4920) * heading * intro text * Update McparPdfExport.tsx * field sections * tests for new components * table styling * dynamic fields table layout * Update parsing.test.tsx * updating tests * moved directories * Update McparReviewSubmitPage.tsx * clean it up * pr requests * more requests * even more requests * alt text fix * testing fixes * cleanup Co-authored-by: Garrett Rabian <garrett@coforma.io> * add dynamic fields (#4958) * add dynamic fields * add styling * PR comment update * parse field data (#4970) * parse field data * choice list support * parsing tests * Mdct 2103 (#4977) * set empty fields to no response text * set empty fields to no response text * set empty fields to no response text * Add recursion for children sections for Export * MDCT-2122: PDF Metadata (#4988) * Metadata tags for MCPAR report PDF * fix unit test * add print button to review page (#5001) * add print button to review page * add print button to review page * add print button to review page * drawer form data (#4994) * drawer form data * Update ExportedReportSubsection.tsx * Jest testing (#5028) * drawerform * dropdown * Swap to wrapper for each export section * Prince UI Integration (#5037) * prince connection * unit tests * coverage * prettier * take out console log Co-authored-by: juliuscaesar <caesarnuzzolo@Coforma-WTWWRT94NR-Caesar-Nuzzolo.local> * Mdct 2125 (#5078) * add modalDrawers to pdf * wip * wip * wip * add z-index * wip * do the chakra thing * wip * wip * wip * ? * wip * fix indicators and some styling Co-authored-by: juliuscaesar <caesarnuzzolo@Coforma-WTWWRT94NR-Caesar-Nuzzolo.local> * Nested children (#5069) * save * nested values in plan drawers * convert to switch statement * separated functions * remove unused variables * remove unused files * remove old tests * Export unit tests (#5099) * entitycard print version teests * test status indicators * Exported Drawer Report Section tests * ExportedModalDrawerReportSection * Write tests for and update export section typings * Remove Section heading for review and submit for export * parsing * ExportedStandardReportSection test Co-authored-by: juliuscaesar <caesarnuzzolo@Coforma-WTWWRT94NR-Caesar-Nuzzolo.local> Co-authored-by: Nicholas Summers <nick@coforma.io> * padding for status icons (#5104) * font size fix * more parsing tests plus icon file change * renaming * extract section heading WIP * nits (#5112) * nits part i * more nits and a bug fix or two * more testing * PR feedback * Update ExportedStandardReportSection.test.tsx * went with no types * Update ExportedDrawerReportSection.tsx Co-authored-by: juliuscaesar <caesarnuzzolo@Coforma-WTWWRT94NR-Caesar-Nuzzolo.local> Co-authored-by: Caesar Nuzzolo <3749120+juliuscaesar@users.noreply.github.com> Co-authored-by: Scott Wambach <scott.wambach@coforma.io> Co-authored-by: Garrett Rabian <garrett@coforma.io> Co-authored-by: Britt <britt.bujacich@gmail.com> Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Nick Summers <ntsummers1@gmail.com> Co-authored-by: Brendan Myers <6362494+BearHanded@users.noreply.github.com> Co-authored-by: Scott Wambach <scott@scottwamba.ch> Co-authored-by: Brax Excell <braxton@coforma.io> Co-authored-by: Braxton Excell <braxton.excell@gmail.com>
* feature flags for PDF * oops * .env example updates * mock LD client * update mcpar for D1.X.8 * coverage! Co-authored-by: Braxton Excell <braxton.excell@gmail.com>
* MDCT-2087 - Extract, Transform, Load (ETL) (#4862) * wip * clean start * wip * see if it runs * reused sanitize functions * remove logs * cleanup * add fallback * test update * scan iteration * need routing change * documentation and modularity * test changes in pipeline * log * more logs * try more waiting * i don't get it * I silly * try outputting old stufF * nvm * promises are for liars * throw async out the window? * forEach can't async * ಠ_ಠ * cleanup * make db changeable Co-authored-by: Scott Wambach <scott@scottwamba.ch> Co-authored-by: brendan <brendan@coforma.io> * Cypress version update and config changes (#4896) * removing feature files and adding video upload * adding admin feature back * as of cypress 8.0 headless not needed (default) * adding back in the mcpar features * updating cypress version. * adjusting retry/timeout variables * extending timeout * removing mcpar * back up to 20 seconds. * optimistically uncommenting tests Co-authored-by: Nick Summers <ntsummers1@gmail.com> * MDCT-2084: Launching LaunchDarkly in the Dark 👻 🚀 (#4791) * launching launchdarkly in the dark * And the React SDK * removing JS SDK * testing a new flag * GH Actions + env example * update env file * adding a new workflow * remove action.yml file * update deploy workflow * take THIS * let's see * seein' some things * testing that sweet launch darkly setup * Removing flags from components + env file * removing node SDK * setting up ld * remove LD code references check * removing key from env_example * crying (#4981) * Adding dynamic form fill for MCPAR (#4964) * Adding dynamic form fill for MCPAR * commenting out existing and merging into 1 file * [MDCT-2101] PDF: Implement Prince Backend (#4995) * add endpoint * some more tests and error catching * ssm variables Co-authored-by: juliuscaesar <caesarnuzzolo@Coforma-WTWWRT94NR-Caesar-Nuzzolo.local> * PrintPDF API Fix (#5016) * add axios to api * more descriptive errors * remove extra line * Just in case * Lowercase Bucketname * Lowercase Bucketname * Lowercase Bucketname * S3 bucket env (#5057) * Adding env example for new s3 bucket * Updating correct example this time. * Update bucket folders to new scheme * Fix formatting on codeowners file * Export (#5100) * Extract Section Heading (WIP) (#5117) * put button on page * update preview route * keep print stuff in intro * Mdct 2102 - PDF: Preview Page setup (#4920) * heading * intro text * Update McparPdfExport.tsx * field sections * tests for new components * table styling * dynamic fields table layout * Update parsing.test.tsx * updating tests * moved directories * Update McparReviewSubmitPage.tsx * clean it up * pr requests * more requests * even more requests * alt text fix * testing fixes * cleanup Co-authored-by: Garrett Rabian <garrett@coforma.io> * add dynamic fields (#4958) * add dynamic fields * add styling * PR comment update * parse field data (#4970) * parse field data * choice list support * parsing tests * Mdct 2103 (#4977) * set empty fields to no response text * set empty fields to no response text * set empty fields to no response text * Add recursion for children sections for Export * MDCT-2122: PDF Metadata (#4988) * Metadata tags for MCPAR report PDF * fix unit test * add print button to review page (#5001) * add print button to review page * add print button to review page * add print button to review page * drawer form data (#4994) * drawer form data * Update ExportedReportSubsection.tsx * Jest testing (#5028) * drawerform * dropdown * Swap to wrapper for each export section * Prince UI Integration (#5037) * prince connection * unit tests * coverage * prettier * take out console log Co-authored-by: juliuscaesar <caesarnuzzolo@Coforma-WTWWRT94NR-Caesar-Nuzzolo.local> * Mdct 2125 (#5078) * add modalDrawers to pdf * wip * wip * wip * add z-index * wip * do the chakra thing * wip * wip * wip * ? * wip * fix indicators and some styling Co-authored-by: juliuscaesar <caesarnuzzolo@Coforma-WTWWRT94NR-Caesar-Nuzzolo.local> * Nested children (#5069) * save * nested values in plan drawers * convert to switch statement * separated functions * remove unused variables * remove unused files * remove old tests * Export unit tests (#5099) * entitycard print version teests * test status indicators * Exported Drawer Report Section tests * ExportedModalDrawerReportSection * Write tests for and update export section typings * Remove Section heading for review and submit for export * parsing * ExportedStandardReportSection test Co-authored-by: juliuscaesar <caesarnuzzolo@Coforma-WTWWRT94NR-Caesar-Nuzzolo.local> Co-authored-by: Nicholas Summers <nick@coforma.io> * padding for status icons (#5104) * font size fix * more parsing tests plus icon file change * renaming * extract section heading WIP * nits (#5112) * nits part i * more nits and a bug fix or two * more testing * PR feedback * Update ExportedStandardReportSection.test.tsx * went with no types * Update ExportedDrawerReportSection.tsx Co-authored-by: juliuscaesar <caesarnuzzolo@Coforma-WTWWRT94NR-Caesar-Nuzzolo.local> Co-authored-by: Caesar Nuzzolo <3749120+juliuscaesar@users.noreply.github.com> Co-authored-by: Scott Wambach <scott.wambach@coforma.io> Co-authored-by: Garrett Rabian <garrett@coforma.io> Co-authored-by: Britt <britt.bujacich@gmail.com> Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Nick Summers <ntsummers1@gmail.com> Co-authored-by: Brendan Myers <6362494+BearHanded@users.noreply.github.com> Co-authored-by: Scott Wambach <scott@scottwamba.ch> Co-authored-by: Brax Excell <braxton@coforma.io> Co-authored-by: Braxton Excell <braxton.excell@gmail.com> * Feature Flags for PDF (#5121) * feature flags for PDF * oops * .env example updates * mock LD client * update mcpar for D1.X.8 * coverage! Co-authored-by: Braxton Excell <braxton.excell@gmail.com> * fix sidebar e2e test (#5134) * getStatesReports timing out, config change (#5142) Co-authored-by: Garrett <57802560+gmrabian@users.noreply.github.com> Co-authored-by: Scott Wambach <scott@scottwamba.ch> Co-authored-by: brendan <brendan@coforma.io> Co-authored-by: Thomas Blackwell <thomas.blackwell@coforma.io> Co-authored-by: Nick Summers <ntsummers1@gmail.com> Co-authored-by: Caesar Nuzzolo <3749120+juliuscaesar@users.noreply.github.com> Co-authored-by: juliuscaesar <caesarnuzzolo@Coforma-WTWWRT94NR-Caesar-Nuzzolo.local> Co-authored-by: Brendan Myers <6362494+BearHanded@users.noreply.github.com> Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Scott Wambach <scott.wambach@coforma.io> Co-authored-by: Garrett Rabian <garrett@coforma.io> Co-authored-by: Britt <britt.bujacich@gmail.com> Co-authored-by: Brax Excell <braxton@coforma.io> Co-authored-by: Braxton Excell <braxton.excell@gmail.com>
export fixes from design feedback
fix small failures
Main --> Val
TheDanMiller
requested review from
karla-vm,
BearHanded,
braxex,
gmrabian,
ntsummers1,
juliuscaesar,
scwambach,
britt-mo and
tblackwe
as code owners
December 22, 2022 15:24
britt-mo
approved these changes
Dec 22, 2022
karla-vm
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no squashing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export