Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a half-implemented feature; the ability to deactivate users within the app.
Background: SEDS user data is split across internal (dynamodb) and external (IDM) systems. In non-dev environments, users must exist in IDM before they can log in to SEDS. Once they exist in SEDS, details like their state list and role can be added or changed in dynamodb; from that point forward we consider dynamo to be authoritative. The isActive flag was intended to be such a detail, but even though we added code to manage this flag, we never changed any part of the app to read the flag. Rather than completing that feature, we will henceforth rely on IDM for user deletion/deactivation.
This allows us to remove a good deal of code:
Additionally, this PR contains a migration to purge the isActive flag from all existing users. A list of all users which had isActive set to false has been collected and is in the Business Owners' hands; they will do whatever is appropriate for those users in IDM and in SEDS. Once this migration has run in all environments, there will be no lingering traces of isActive anywhere in the app.
Related ticket(s)
CMDCT-3230
How to test
Cloudfront url: https://d3k0z4kfh0z5fc.cloudfront.net/
(After merging into master)
Notes
n/a
Pre-review checklist
[ ] I have added thorough tests, if necessary[ ] I have updated relevant documentation, if necessary[ ] I have manually tested this PR in the deployed cloud environmentPre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
[ ] These changes are significant enough to require an update to the SIA.[ ] These changes are significant enough to require a penetration test.