Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - First run issue - Scan def updater isn't run #75

Closed
mdial89f opened this issue Oct 13, 2020 · 1 comment · Fixed by #76
Closed

Bug - First run issue - Scan def updater isn't run #75

mdial89f opened this issue Oct 13, 2020 · 1 comment · Fixed by #76
Assignees
@mdial89f
Labels
bug Something isn't working
Projects
macpro-quickstart-serverless

Comments

@mdial89f
Copy link
Contributor

The scan definition updater is run on a schedule.
On deployments of new environments, there is a time where the environment is up and usable, but the scan definition uploader hasn't run yet.
This breaks the app; all scans fail saying 'key doesn't exist'... that's the definitions key.

Although it's a second or two time hit, simply invoking the definition uploader lambda on deploy should fix this. The pattern that's been used is serverless-plugin-scripts hook calling serverless invoke -f at deploy:finalize. Although this specific code was removed later on, you can see the pattern for this here: https://github.com/CMSgov/macpro-quickstart-serverless/pull/36/files

AC:

  • The definition uploader function is guaranteed to have run before new environments are up and expected to be healthy.
@mdial89f mdial89f added the bug Something isn't working label Oct 13, 2020
@mdial89f
Copy link
Contributor Author

mdial89f commented Oct 13, 2020 •
edited
Loading

Pasting the relevant code from the above linked PR
https://github.com/CMSgov/macpro-quickstart-serverless/pull/36/files#diff-df7e8032450282aa420df0cae8de4a03e1816a6b34cc0dfb49e3a14a87b0e755R10-R21

@mdial89f mdial89f self-assigned this Oct 13, 2020
@mdial89f mdial89f moved this from To do to In progress in macpro-quickstart-serverless Oct 13, 2020
mdial89f added a commit that referenced this issue Oct 13, 2020
@mdial89f
Run the scan definitions uploader on deploy... should fix #75
61f7858
@mdial89f mdial89f mentioned this issue Oct 13, 2020
Merged
macpro-quickstart-serverless automation moved this from In progress to Done Oct 13, 2020
mdial89f added a commit that referenced this issue Oct 13, 2020
@mdial89f
Run the definition uploader on deploy (#76)
0aa1824 
* Run the scan definitions uploader on deploy... should fix #75

* Invoke the Def updater lambda asynchronously.  It takes about 45 seconds and we don't need to wait for it

Co-authored-by: Mike Dial <mdial@collabralink.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdial89f mdial89f

Labels
bug Something isn't working
Projects
macpro-quickstart-serverless
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run the definition uploader on deploy Enterprise-CMCS/macpro-quickstart-serverless
1 participant
@mdial89f