Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the deploy workflow #84

Closed
mdial89f opened this issue Oct 20, 2020 · 1 comment · Fixed by #85
Closed

Rename the deploy workflow #84

mdial89f opened this issue Oct 20, 2020 · 1 comment · Fixed by #85

Comments

@mdial89f
Copy link
Contributor

This is simple but an issue is good for tracking purposes.

The deploy workflow for github actions is currently named config.yml
That should be renamed to deploy.yml
Likewise, the workflow itself should be renamed from Build to Deploy

This could temporarily break the github lock script if the right order of events happened, so I want to include this as part of the other breaking changes in release 1.x

AC:

  • Github actions workflow and file is renamed as approrpriate.
@mdial89f
Copy link
Contributor Author

be sure to test the lock functionality
make sure the workflow name isnt somewhere in that script
make sure it still blocks concurrent deploys

@mdial89f mdial89f moved this from Done to In progress in macpro-quickstart-serverless Oct 20, 2020
@mdial89f mdial89f self-assigned this Oct 20, 2020
macpro-quickstart-serverless automation moved this from In progress to Done Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant