Add termination protection and refactor GHA caching #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #111
Closes #107
This adds cloudformation termination protection for a list of stage names that are commonly used for important environments. This has the effect of requiring a --force flag to be set if destroying a protected stage with serverless (something we never do programatically, so a human would need to set that). In the console, to delete a protected stack, the termination protection must be manually edited to be disabled.
We have a few safeguards in place to prevent deletion of important stages, but this is a huge add since it's protection baked into cloudformation itself.
Obviously a project only needs to protect the stages it cares about (usually master, val, production), but I added all that we've seen to be more safe than sorry.
The github actions caching logic was also refactored. Same end result, just less code and less things to update when adding a new service.
See issues for more detail.