Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed accessiblity issues #1

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Fixed accessiblity issues #1

merged 2 commits into from
Feb 25, 2020

Conversation

pradipparkale269
Copy link
Contributor

  1. Added hidden label to satisfy accessibility.
  2. Added label with sr-only class.
  3. Added tabindex to fix tab to move the mouse control to maximize button.

@pradipparkale269
Fixed accessiblity issues
8751004 
   1) Added hidden label to satisfy accessibility.
   2) Added label with sr-only class.
   3) Added tabindex to fix tab to move the mouse control to maximize button.
adityatoshniwal
adityatoshniwal reviewed Feb 24, 2020
View reviewed changes
Copy link

@adityatoshniwal adityatoshniwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

The changes in the file - src/js/dialog/intro.js where you've used sr-only class won't work in alertify as sr-only class is from bootstrap. Use aria-label="reset", that's it. Remove the span and aria-labelledby.

Other changes looks good to me.

Thanks.

@adityatoshniwal
Copy link

Looks good to me. @asheshv can you please approve and commit ?

@dpage dpage merged commit 72c1d79 into EnterpriseDB:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityatoshniwal adityatoshniwal adityatoshniwal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pradipparkale269 @adityatoshniwal @dpage