Change to address asymmetric treatment of bytea <->binary values #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varbinary and bytea values can be compared to escaped strings in mysql and postgres respectively, but with different formats (X'0102' vs '\x0101') up until now mysql_fdw had been sending the postgres string to mysql so equality comparisons would always fail. This change converts the postgres string to mysql's format before sending.
ibrarahmad
suggested changes
Jul 25, 2017
There was a problem hiding this comment.
You need to create a new issue(bug/feature) and then in commit you should write comments along with that issue number.
Example.
Issue - (#10) - Single line comment.
Detail description of the commit.
deparse.c
Outdated
| @@ -758,6 +758,14 @@ mysql_deparse_const(Const *node, deparse_expr_cxt *context) | |||
| case INTERVALOID: | |||
| deparse_interval(buf, node->constvalue); | |||
| break; | |||
| case BYTEAOID: | |||
| //the string for BYTEA always seems to be in the format "\\x##" | |||
There was a problem hiding this comment.
Please change the comment style.
Changes to push down binary data in a way that mysql expects. Added a BYTEAOID case to mysql_deparse_const to change the format of the hex string from '\xdddd' to X'dddd' where d is a hexdigit
|
@ibrarahmad I believe I have now done what you were asking for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
varbinary and bytea values can be compared to escaped strings in mysql and postgres respectively, but with different formats (X'0102' vs '\x0101') up until now mysql_fdw had been sending the postgres string to mysql so equality comparisons would always fail. This change converts the postgres string to mysql's format before sending.
Hopefully this change meets your approval. Thanks for creating mysql_fdw :)