Quick fixes in mysqlReScanForeignScan #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 11, 2012 15:11
mysql_row_seek() expects a MYSQL_ROW_OFFSET object rather than the (first) row index number we were giving it. Use mysql_data_seek() instead.
If we run as the inner node of a nested loop mysqlReScanForeignScan may be called first, prior to the result being initialized, causing a segfault in the back end. There's nothing to be done in that case anyway, so just ignore it.
dpage
added a commit
that referenced
this pull request
Apr 15, 2012
Quick fixes in mysqlReScanForeignScan
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why the rescan was getting hit before the iterate function that would have initialised it, but without that test it was causing a segfault.