Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App is logging clear password in connection string at WARNING level #780

Open
mulder999 opened this issue Dec 5, 2022 · 2 comments
Open

Comments

@mulder999
Copy link

Method dbutils::is_server_available (other methods seems to suffer from same issue) is reporting full connection string with password in clear at WARNING level.

Reproduction is possible for example when connection are exhausted on the corresponding node.

@ibarwick
Copy link
Collaborator

ibarwick commented Dec 6, 2022

Per https://repmgr.org/docs/current/configuration-password-management.html:

We strongly advise against including the password in the conninfo string, as this will result in the database password being exposed in various places, including in the repmgr.conf file, the repmgr.nodes table, any output generated by repmgr which lists the node conninfo strings (e.g. repmgr cluster show) and in the repmgr log file, particularly at log_level=DEBUG.

@mulder999
Copy link
Author

Thanks for reply, according to your own documentation, logging the connection string at any level above DEBUG (in this case WARNING) was not expected and provides no benefit to any legitimate user.

Also logging the password in clear text is against OWASP Recommendation.

@mulder999 mulder999 changed the title App is logging clear password in connection string App is logging clear password in connection string at WARNING level Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants