fix: app crashing due to translation errors

added info about language change
Enubia · Mar 7, 2023 · 1fb94bf · 1fb94bf
1 parent 69083fd
commit 1fb94bf
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 28 deletions.
diff --git a/i18n/locales/de-DE.json b/i18n/locales/de-DE.json
@@ -34,7 +34,8 @@
             },
             "general": {
                 "locale-change": {
-                    "label": "Wähle deine bevorzugte Sprache"
+                    "label": "Wähle deine bevorzugte Sprache",
+                    "info": "Um die Sprache der ganzen App zu ändern musst du GhostChat einmal neu starten."
                 },
                 "pre-release": {
                     "checkbox-label": "Nimm teil an frühen Versionen",
@@ -88,11 +89,7 @@
         }
     },
     "version-check": {
-        "loading-messages": [
-            "Loading hot chat actions",
-            "Crunching latest numbers",
-            "Preparing new followers"
-        ],
+        "loading-message": "Suche nach Updates",
         "update-available": "Version {version} ist verfügbar, der Download startet automatisch!",
         "download-finished": "Der Download ist fertig, die neue Version wird mit beenden der App installiert!",
         "error": "Ein fehler ist aufgetreten während des Downloads, bitte melde das in Discord!",

diff --git a/i18n/locales/en-US.json b/i18n/locales/en-US.json
@@ -34,7 +34,8 @@
             },
             "general": {
                 "locale-change": {
-                    "label": "Select your preferred language"
+                    "label": "Select your preferred language",
+                    "info": "Please note that in order for this change to take effect on the whole application you'll need to restart it once."
                 },
                 "pre-release": {
                     "checkbox-label": "Participate in pre-release versions",
@@ -88,11 +89,7 @@
         }
     },
     "version-check": {
-        "loading-messages": [
-            "Loading hot chat actions",
-            "Crunching latest numbers",
-            "Preparing new followers"
-        ],
+        "loading-message": "Checking for updates",
         "update-available": "Version {version} is available, download will start automagically",
         "download-finished": "Download finished, new version will be applied on restart",
         "error": "Some error happened during download, please report this in the discord!",

diff --git a/i18n/locales/es-AR.json b/i18n/locales/es-AR.json
@@ -34,7 +34,8 @@
             },
             "general": {
                 "locale-change": {
-                    "label": "Seleccionar tu idioma preferido"
+                    "label": "Seleccionar tu idioma preferido",
+                    "info": "Please note that in order for this change to take effect on the whole application you'll need to restart it once."
                 },
                 "pre-release": {
                     "checkbox-label": "Participa en las versiones previas al lanzamiento",
@@ -88,11 +89,7 @@
         }
     },
     "version-check": {
-        "loading-messages": [
-            "Cargando acciones rápidas del chat",
-            "Procesando las últimas cifras",
-            "Preparando nuevos seguidores"
-        ],
+        "loading-message": "Checking for updates",
         "update-available": "La versión {version} está disponible, la descarga va a comenzar automaticamente",
         "download-finished": "La descarga finalizó, la nueva versión va a ser aplicada al reiniciar",
         "error": "Se produjeron algunos errores durante la descarga, por favor reportá esto en el discord!",

diff --git a/i18n/locales/ko-KR.json b/i18n/locales/ko-KR.json
@@ -34,7 +34,8 @@
             },
             "general": {
                 "locale-change": {
-                    "label": "원하는 언어 선택"
+                    "label": "원하는 언어 선택",
+                    "info": "Please note that in order for this change to take effect on the whole application you'll need to restart it once."
                 },
                 "pre-release": {
                     "checkbox-label": "사전 릴리즈 버전에 참여하기",
@@ -88,11 +89,7 @@
         }
     },
     "version-check": {
-        "loading-messages": [
-            "Loading hot chat actions",
-            "Crunching latest numbers",
-            "Preparing new followers"
-        ],
+        "loading-message": "업데이트 확인 중",
         "update-available": "Version {version} is available, download will start automagically",
         "download-finished": "다운로드 완료, 재시작 시 새 버전이 적용됩니다",
         "error": "다운로드 중에 오류가 발생했습니다, Discord에 제보해주세요!",

diff --git a/src/components/settings/General.vue b/src/components/settings/General.vue
@@ -8,7 +8,12 @@
 				</option>
 			</select>
 		</label>
+		<div></div>
+		<small v-if="store.get('general.language') !== $i18n.locale" class="info">
+			{{ t('settings.document.general.locale-change.info') }}
+		</small>
 	</div>
+	<hr />
 	<div id="beta-updates">
 		<label for="beta-updates-input" class="align-elements">
 			<input

diff --git a/src/pages/VersionCheck.vue b/src/pages/VersionCheck.vue
@@ -36,13 +36,11 @@ import { useI18n } from 'vue-i18n';
 
 import { IpcEvent } from '../../shared/constants';
 
-const { t, tm } = useI18n();
-
-const loadingMessages = tm('version-check.loading-messages');
+const { t } = useI18n();
 
 const emit = defineEmits(['removeLoading']);
 
-const message = ref(loadingMessages[Math.floor(Math.random() * loadingMessages.length)]);
+const message = ref(t('version-check.loading-message'));
 const showManualDownloadMessage = ref(false);
 const version = ref('');