New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1248] synonym for 'solid astronomical body part' --> 'landform' #1253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at Steve's landform definition and the definition for 'solid astronomical body part' I have no objection to including this change.
'produced by natural causes' - perhaps 'created by natural Earth processes'. Noted distinction of natural and not natural land forms |
@meganrwong the existing textual definition of http://purl.obolibrary.org/obo/ENVO_00000191 is "A part of an astronomical body which is primarily composed of a continuous volume of solid material, shaped by one or more environmental processes." which I think more or less matches your suggestion. This is attributed to Wikipedia:Landform though I don't see those exact words now |
I agree and approve this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's merge this
however I want to note a minor terminological issue in that 2 terms have syns of the form "X landform"
http://www.ontobee.org/search?ontology=ENVO&keywords=landform&submit=Search+terms
but are not SCs of SABP
|
lets' move the ancilliary discussion to a new ticket - sorry for diverting us - we need to get better and faster at merging clearly good PRs like this one, sorry for the delay! |
All good thanks @cmungall for merging. |
Fixes #1248