Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1248] synonym for 'solid astronomical body part' --> 'landform' #1253

Merged
merged 1 commit into from Mar 9, 2022

Conversation

dr-shorthair
Copy link

@dr-shorthair dr-shorthair commented Nov 24, 2021

Fixes #1248

@dr-shorthair dr-shorthair changed the title Add synonym for 'solid astronomical body part' --> 'landform' [#1248] Add synonym for 'solid astronomical body part' --> 'landform' Nov 24, 2021
@dr-shorthair dr-shorthair changed the title [#1248] Add synonym for 'solid astronomical body part' --> 'landform' [#1248] synonym for 'solid astronomical body part' --> 'landform' Nov 24, 2021
@dr-shorthair dr-shorthair requested review from diatomsRcool, rduerr and a team November 24, 2021 23:50
Copy link
Contributor

@rduerr rduerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at Steve's landform definition and the definition for 'solid astronomical body part' I have no objection to including this change.

@meganrwong
Copy link

'produced by natural causes' - perhaps 'created by natural Earth processes'.
From here - http://inspire.ec.europa.eu/featureconcept/NaturalGeomorphologicFeature

Noted distinction of natural and not natural land forms
http://inspire.ec.europa.eu/featureconcept/GeomorphologicFeature

@dr-shorthair
Copy link
Author

@meganrwong the existing textual definition of http://purl.obolibrary.org/obo/ENVO_00000191 is "A part of an astronomical body which is primarily composed of a continuous volume of solid material, shaped by one or more environmental processes." which I think more or less matches your suggestion.

This is attributed to Wikipedia:Landform though I don't see those exact words now

@kaiiam kaiiam mentioned this pull request Nov 25, 2021
@kaiiam
Copy link
Contributor

kaiiam commented Nov 25, 2021

I agree and approve this.

Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge this

however I want to note a minor terminological issue in that 2 terms have syns of the form "X landform"

http://www.ontobee.org/search?ontology=ENVO&keywords=landform&submit=Search+terms

but are not SCs of SABP

@kaiiam
Copy link
Contributor

kaiiam commented Jan 19, 2022

volcanic feature is subclass to astronomical body part instead of solid astronomical body part so I think this could be moved to the more specific parent solid astronomical body part.

glacial feature is a material entity with subclasses like ice mass and snow, hence use of the word "feature" is inconsistent here. This relates to our ongoing ESIP cryosphere and polar work. Perhaps we can improve on this. Any suggestions?

@cmungall
Copy link
Member

cmungall commented Mar 9, 2022

lets' move the ancilliary discussion to a new ticket - sorry for diverting us - we need to get better and faster at merging clearly good PRs like this one, sorry for the delay!

@cmungall cmungall merged commit 1f0c547 into EnvironmentOntology:master Mar 9, 2022
@kaiiam
Copy link
Contributor

kaiiam commented Mar 9, 2022

All good thanks @cmungall for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NTR: landform
5 participants