Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Krishna to issue 361 #1339

Merged
merged 4 commits into from Aug 12, 2022
Merged

Krishna to issue 361 #1339

merged 4 commits into from Aug 12, 2022

Conversation

pbuttigieg
Copy link
Member

Closes #1244
Closes #361

@pbuttigieg pbuttigieg self-assigned this Aug 12, 2022
@pbuttigieg
Copy link
Member Author

pbuttigieg commented Aug 12, 2022 •
edited

Content review:

  • runoff - definition somewhat convoluted, simplifying and adding sources. 🔴 Conflict between definition in New class: runoff, runoff volume #361 and PR - do you want the flow or the water itself represented @marieALaporte ? The latter is consistent with runoff volume semantics. If you need revision, please open another PR.
  • runoff volume - autogenerated, Looks fine, if a little awkward (the auto definitions usually sound a little weird)

Additionally:

  • dbXrefs were literals, changed to IRIs

@pbuttigieg pbuttigieg merged commit f35d862 into master Aug 12, 2022
@pbuttigieg pbuttigieg deleted the KrishnaTO-issue-361 branch August 12, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pbuttigieg pbuttigieg

Labels
soil
Projects
agronomy
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New class: runoff, runoff volume
2 participants
@pbuttigieg @KrishnaTO