Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top level cleanup #1345

Merged
merged 5 commits into from Aug 16, 2022
Merged

Top level cleanup #1345

merged 5 commits into from Aug 16, 2022

Conversation

pbuttigieg
Copy link
Member

Cleaning up orphaned and oddly imported ; used class at the top-level.

image

  • Many of these were asserted in some axiom, but never imported.
  • Some are more puzzling: they seem to be orphaned because their superclasses were asserted in equivalence axioms which were not imported.
  • Some, like CHEBI:role, are asserted as equivalent to and a subclass of BFO:role in our PATO import, it seems, which I think gunks things up.

@pbuttigieg
Copy link
Member Author

we're currently here:
image

But I had to assert stuff in ENVO that I don't think I should have to:

Other issues are expected.

@pbuttigieg
Copy link
Member Author

Looks better now

image

The orphan ENVO term will be addressed when we close the remaining PRs from @marieALaporte 's team.

I have no idea what's up with the CHEBI vs BFO role thing that we're apparently coming in from our PATO import.

@pbuttigieg pbuttigieg merged commit 45eb70c into master Aug 16, 2022
@pbuttigieg pbuttigieg deleted the topLevelCleanup branch August 16, 2022 09:02
@pbuttigieg pbuttigieg mentioned this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant