Issue 1409 pull request #1412
Issue 1409 pull request #1412
Conversation
Fixed SWEET labels
Added sweet prefixes!
Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>
Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>
Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>
Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>
Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>
Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>
* Create sssom-qc.yml * Create Makefile
| ENVO:01001509 terrestrial ice calf soreac:Calf calf skos:broadMatch semapv:ManualMappingCuration SWEET Calf is less specific than ENVO terrestrial ice calf | ||
| ENVO:01001611 thawing process soprocsc:Thawing thawing skos:closeMatch semapv:ManualMappingCuration Candidate Exact match if SWEET adopts the ENVO definition. | ||
| ENVO:03000085 thermokarst sorealg:Thermokarst thermokarst skos:closeMatch semapv:ManualMappingCuration In SWEET this is a landform, which is accurate - need to compare upper level layers to determine if an exact match could be made if SWEET adopted the ENVO definition | ||
| ENVO:00000254 till plain sorealg:TillPlain till plain skos:relatedMatch semapv:ManualMappingCuration Despite having identical definitions, the SWEET till plain is a geometrical object; while the ENVO till plain is a material entity |
There was a problem hiding this comment.
Hmm, I think this should be close? This is the sweet concept:
I have seen many cases where sweet confuses things under geometrical branches but this doesn't seem to be one of them?
There was a problem hiding this comment.
But LandRegion is a subclass of http://sweetontology.net/reprSpaceGeometry/GeometricalObject which is a subclass of http://sweetontology.net/reprMath/NumericalEntity! So now I am really confused... The ENVO version of a till plain is not a numerical entity!!!
There was a problem hiding this comment.
@rduerr where are you seeing that http://cor.esipfed.org/ont?iri=http://sweetontology.net/realmLandform/LandRegion is a subclass of GeometricalObject? The OAK diagram above shows the complete paths to root, and this is consistent with the URIs.
|
This PR has been open since March. I didn't mean to block it with my comment. I think there are issues in the mapping methodology but it's better we merge and then iteratively improve. |
Please check this over carefully as it was cut/paste edited!!! Also, note the 2 undone items which need someone else to complete (or instructions to me)...