Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GC.at_preserve #122

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Support GC.at_preserve #122

merged 1 commit into from
Sep 15, 2021

Conversation

vchuravy
Copy link
Member

No description provided.

Project.toml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

Merging #122 (c1b32b1) into master (9742b5f) will decrease coverage by 2.20%.
The diff coverage is 47.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   77.15%   74.95%   -2.21%     
==========================================
  Files          12       12              
  Lines        1922     2076     +154     
==========================================
+ Hits         1483     1556      +73     
- Misses        439      520      +81     
Impacted Files Coverage Δ
src/api.jl 37.50% <0.00%> (-0.88%) ⬇️
src/compiler.jl 77.54% <46.32%> (-3.70%) ⬇️
src/compiler/validation.jl 63.44% <61.11%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9742b5f...c1b32b1. Read the comment docs.

@wsmoses
Copy link
Member

wsmoses commented Sep 15, 2021

@vchuravy rebased, this now passes

Copy link
Member Author

@vchuravy vchuravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to split the MPI changes into their own PR

src/compiler.jl Outdated Show resolved Hide resolved
src/compiler/validation.jl Outdated Show resolved Hide resolved
src/compiler.jl Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants