Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Julia 1.11 #1372

Merged
merged 8 commits into from
Jun 13, 2024
Merged

Support Julia 1.11 #1372

merged 8 commits into from
Jun 13, 2024

Conversation

vchuravy
Copy link
Member

  • Test against v1.11
  • WIP: adapt to 1.11 changes

src/compiler/interpreter.jl Show resolved Hide resolved
src/compiler/interpreter.jl Show resolved Hide resolved

function EnzymeInterpreter(cache::CodeCache, mt::Union{Nothing,Core.MethodTable}, world::UInt, mode::API.CDerivativeMode)
@assert world <= Base.get_world_counter()
function EnzymeInterpreter(cache::CodeCache, mt::Union{Nothing,Core.MethodTable}, world::UInt, mode::API.CDerivativeMode)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
function EnzymeInterpreter(cache::CodeCache, mt::Union{Nothing,Core.MethodTable}, world::UInt, mode::API.CDerivativeMode)
function EnzymeInterpreter(cache::CodeCache, mt::Union{Nothing,Core.MethodTable},
world::UInt, mode::API.CDerivativeMode)

Comment on lines 43 to 45
return EnzymeInterpreter(
cache,
mt,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
return EnzymeInterpreter(
cache,
mt,
return EnzymeInterpreter(cache,
mt,

src/compiler/interpreter.jl Show resolved Hide resolved
src/compiler/interpreter.jl Show resolved Hide resolved
src/compiler/interpreter.jl Show resolved Hide resolved
src/compiler/interpreter.jl Outdated Show resolved Hide resolved
@wsmoses
Copy link
Member

wsmoses commented Mar 31, 2024

This is definitely required, but the bigger issue is almost certainly adapting to the new pipeline changes.

src/compiler/interpreter.jl Outdated Show resolved Hide resolved
src/compiler/interpreter.jl Outdated Show resolved Hide resolved
Copy link
Contributor

Benchmark Results

main 6cd6d52... main/6cd6d52e0e227d...
basics/overhead 4.64 ± 0.01 ns 4.64 ± 0.01 ns 1
time_to_load 0.414 ± 0.0046 s 0.409 ± 0.0016 s 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.45%. Comparing base (bd60907) to head (6cd6d52).

Files Patch % Lines
src/compiler.jl 0.00% 2 Missing ⚠️
src/compiler/interpreter.jl 85.71% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1372      +/-   ##
==========================================
+ Coverage   68.30%   71.45%   +3.14%     
==========================================
  Files          30       30              
  Lines       11953    12045      +92     
==========================================
+ Hits         8165     8607     +442     
+ Misses       3788     3438     -350     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsmoses wsmoses marked this pull request as ready for review June 13, 2024 02:25
@wsmoses
Copy link
Member

wsmoses commented Jun 13, 2024

Merging WIP, will continue in separate PRs

@wsmoses wsmoses merged commit fb6f959 into main Jun 13, 2024
40 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants