Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MixedDuplicated for custom rules #1534

Merged
merged 7 commits into from
Jun 13, 2024
Merged

MixedDuplicated for custom rules #1534

merged 7 commits into from
Jun 13, 2024

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Jun 11, 2024

No description provided.

@wsmoses wsmoses requested a review from vchuravy June 11, 2024 22:35
Copy link
Contributor

github-actions bot commented Jun 11, 2024

Benchmark Results

main fdb235f... main/fdb235fb5c0f7d...
basics/overhead 4.64 ± 0.01 ns 4.64 ± 0.01 ns 1
time_to_load 0.409 ± 0.0058 s 0.42 ± 0.0098 s 0.974

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 68.29%. Comparing base (bd60907) to head (fdb235f).

Files Patch % Lines
src/rules/customrules.jl 87.69% 8 Missing ⚠️
src/compiler.jl 85.71% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1534      +/-   ##
==========================================
- Coverage   68.30%   68.29%   -0.02%     
==========================================
  Files          30       30              
  Lines       11953    12029      +76     
==========================================
+ Hits         8165     8215      +50     
- Misses       3788     3814      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsmoses wsmoses merged commit 15f9bb1 into main Jun 13, 2024
39 of 56 checks passed
@wsmoses wsmoses deleted the mixdup branch June 13, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants