Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed activity for getfield #1535

Merged
merged 11 commits into from
Jun 14, 2024
Merged

Mixed activity for getfield #1535

merged 11 commits into from
Jun 14, 2024

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Jun 13, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Jun 13, 2024

Benchmark Results

main ab7cee5... main/ab7cee5966c41d...
basics/overhead 4.34 ± 0.01 ns 4.03 ± 0.001 ns 1.08
time_to_load 0.411 ± 0.006 s 0.404 ± 0.0028 s 1.02

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 83.52490% with 43 lines in your changes missing coverage. Please review.

Project coverage is 68.18%. Comparing base (835b6d5) to head (ab7cee5).

Files Patch % Lines
src/rules/jitrules.jl 83.11% 26 Missing ⚠️
src/Enzyme.jl 40.00% 6 Missing ⚠️
src/compiler.jl 91.17% 6 Missing ⚠️
src/rules/typeunstablerules.jl 82.75% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1535      +/-   ##
==========================================
- Coverage   73.96%   68.18%   -5.78%     
==========================================
  Files          30       30              
  Lines       12267    12198      -69     
==========================================
- Hits         9073     8317     -756     
- Misses       3194     3881     +687     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsmoses wsmoses merged commit a889bb6 into main Jun 14, 2024
40 of 56 checks passed
@wsmoses wsmoses deleted the magf branch June 14, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants