Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pick_batchsize #1545

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Implement pick_batchsize #1545

wants to merge 6 commits into from

Conversation

gdalle
Copy link
Contributor

@gdalle gdalle commented Jun 18, 2024

Fix #1542 by implementing a constant heuristic for picking chunk size.

src/utils.jl Outdated Show resolved Hide resolved
src/utils.jl Outdated Show resolved Hide resolved
@gdalle gdalle requested a review from vchuravy June 21, 2024 15:19
src/utils.jl Outdated Show resolved Hide resolved
@gdalle gdalle requested a review from wsmoses June 27, 2024 13:13
@gdalle
Copy link
Contributor Author

gdalle commented Jun 27, 2024

Should this be renamed to pick_batchsize? On the one hand, the type is BatchDuplicated, but on the other hand, jacobian and gradient call it chunk

@wsmoses
Copy link
Member

wsmoses commented Jun 27, 2024

Sure, batchsize sgtm.

@wsmoses
Copy link
Member

wsmoses commented Jun 27, 2024

Otherwise, this looks good to me once test pass

@gdalle gdalle changed the title Implement pick_chunksize Implement pick_batchsize Jun 28, 2024
@gdalle
Copy link
Contributor Author

gdalle commented Jun 28, 2024

I think test failures are unrelated? The tests I introduced pass locally

@gdalle
Copy link
Contributor Author

gdalle commented Jul 2, 2024

is this acceptable? it's hard to know given all the failing tests

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (4da44dd) to head (9f02369).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1545   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files           8        8           
  Lines         406      406           
=======================================
  Hits          391      391           
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heuristic for picking the chunk/batch size?
4 participants