Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error on unknown concrete type #290

Merged
merged 4 commits into from
Apr 27, 2022
Merged

Better error on unknown concrete type #290

merged 4 commits into from
Apr 27, 2022

Conversation

vchuravy
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #290 (0b52c0d) into main (a7c1442) will decrease coverage by 0.53%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
- Coverage   78.66%   78.12%   -0.54%     
==========================================
  Files          16       16              
  Lines        3224     3228       +4     
==========================================
- Hits         2536     2522      -14     
- Misses        688      706      +18     
Impacted Files Coverage Δ
src/compiler.jl 79.40% <25.00%> (-0.12%) ⬇️
src/compiler/orcv2.jl 61.90% <0.00%> (-10.48%) ⬇️
src/compiler/orcv1.jl 76.92% <0.00%> (-3.85%) ⬇️
src/compiler/validation.jl 61.85% <0.00%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c1442...0b52c0d. Read the comment docs.

src/compiler.jl Outdated Show resolved Hide resolved
src/compiler.jl Outdated Show resolved Hide resolved
@vchuravy vchuravy merged commit 9b71f35 into main Apr 27, 2022
@vchuravy vchuravy deleted the vc/better_error branch April 27, 2022 20:12
vchuravy added a commit that referenced this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants