Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer error for forward api #469

Merged
merged 1 commit into from
Oct 2, 2022
Merged

Nicer error for forward api #469

merged 1 commit into from
Oct 2, 2022

Conversation

bitmyte
Copy link
Collaborator

@bitmyte bitmyte commented Oct 2, 2022

No description provided.

@wsmoses wsmoses self-requested a review October 2, 2022 05:05
@wsmoses
Copy link
Member

wsmoses commented Oct 2, 2022

Fixes #451

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2022

Codecov Report

Base: 72.87% // Head: 76.16% // Increases project coverage by +3.28% 🎉

Coverage data is based on head (6510e6a) compared to base (6001c83).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   72.87%   76.16%   +3.28%     
==========================================
  Files          17       17              
  Lines        4878     4989     +111     
==========================================
+ Hits         3555     3800     +245     
+ Misses       1323     1189     -134     
Impacted Files Coverage Δ
src/Enzyme.jl 86.25% <85.71%> (+0.03%) ⬆️
src/compiler/pmap.jl 77.54% <0.00%> (-5.22%) ⬇️
src/compiler/optimize.jl 93.01% <0.00%> (-4.84%) ⬇️
src/compiler/orcv2.jl 61.90% <0.00%> (-4.43%) ⬇️
src/typetree.jl 87.30% <0.00%> (+1.58%) ⬆️
src/compiler.jl 75.54% <0.00%> (+1.77%) ⬆️
src/api.jl 60.10% <0.00%> (+3.82%) ⬆️
src/compiler/validation.jl 62.06% <0.00%> (+5.95%) ⬆️
src/compiler/interpreter.jl 100.00% <0.00%> (+36.36%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wsmoses wsmoses merged commit 518cdb3 into main Oct 2, 2022
@wsmoses wsmoses deleted the nicer_forward_api_error branch October 2, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants