Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve inout type rule for constant expression inputs #557

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Dec 15, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2022

Codecov Report

Base: 76.12% // Head: 73.43% // Decreases project coverage by -2.68% ⚠️

Coverage data is based on head (a90eca9) compared to base (70b47bf).
Patch coverage: 23.52% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
- Coverage   76.12%   73.43%   -2.69%     
==========================================
  Files          17       17              
  Lines        5704     5432     -272     
==========================================
- Hits         4342     3989     -353     
- Misses       1362     1443      +81     
Impacted Files Coverage Δ
src/compiler.jl 75.89% <23.52%> (-0.27%) ⬇️
src/compiler/interpreter.jl 26.53% <0.00%> (-65.63%) ⬇️
src/compiler/orcv2.jl 0.00% <0.00%> (-61.91%) ⬇️
src/compiler/utils.jl 58.57% <0.00%> (-37.32%) ⬇️
src/logic.jl 75.00% <0.00%> (-5.00%) ⬇️
src/api.jl 58.91% <0.00%> (-2.78%) ⬇️
src/compiler/validation.jl 59.59% <0.00%> (-2.48%) ⬇️
src/compiler/pmap.jl 75.27% <0.00%> (-2.27%) ⬇️
src/pmap.jl 83.33% <0.00%> (-1.29%) ⬇️
src/typeanalysis.jl 90.00% <0.00%> (-0.91%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wsmoses wsmoses merged commit e6f83aa into main Dec 16, 2022
@vchuravy vchuravy deleted the inout_const branch December 16, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants