Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump workaround #627

Merged
merged 9 commits into from
Feb 11, 2023
Merged

Bump workaround #627

merged 9 commits into from
Feb 11, 2023

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Feb 10, 2023

Fictitious version until lands to test CI

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Base: 73.62% // Head: 65.31% // Decreases project coverage by -8.32% ⚠️

Coverage data is based on head (b647574) compared to base (041c4f4).
Patch coverage: 42.30% of modified lines in pull request are covered.

❗ Current head b647574 differs from pull request most recent head 8d2d10f. Consider uploading reports for the commit 8d2d10f to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
- Coverage   73.62%   65.31%   -8.32%     
==========================================
  Files          18       18              
  Lines        6617     6308     -309     
==========================================
- Hits         4872     4120     -752     
- Misses       1745     2188     +443     
Impacted Files Coverage Δ
src/internal_rules.jl 0.00% <0.00%> (ø)
src/compiler.jl 66.32% <35.48%> (-8.14%) ⬇️
src/compiler/validation.jl 59.74% <91.66%> (-1.90%) ⬇️
src/compiler/interpreter.jl 17.33% <0.00%> (-63.44%) ⬇️
src/compiler/orcv2.jl 0.00% <0.00%> (-61.91%) ⬇️
src/compiler/utils.jl 58.57% <0.00%> (-37.32%) ⬇️
src/logic.jl 75.00% <0.00%> (-5.00%) ⬇️
src/api.jl 59.57% <0.00%> (-4.16%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wsmoses
Copy link
Member Author

wsmoses commented Feb 10, 2023

@vchuravy the workaround fails on 1.9. Did some convention change?

src/compiler.jl Outdated Show resolved Hide resolved
@wsmoses wsmoses merged commit 214d17a into main Feb 11, 2023
@wsmoses wsmoses deleted the workaround branch February 11, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants